Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7503: Fix serializers.test dependency #351

Closed

Conversation

bric3
Copy link
Collaborator

@bric3 bric3 commented Jan 12, 2022

This simple fix properly declares the flightrecorder.test dependency as a test-jar. This fixes compilation issues in IntelliJ especially.


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-7503: Fix serializers.test dependency

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/351/head:pull/351
$ git checkout pull/351

Update a local copy of the PR:
$ git checkout pull/351
$ git pull https://git.openjdk.java.net/jmc pull/351/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 351

View PR using the GUI difftool:
$ git pr show -t 351

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/351.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 12, 2022

👋 Welcome back bric3! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@Suchitainf
Copy link
Collaborator

Seems related to https://bugs.openjdk.java.net/browse/JMC-7406

@thegreystone thegreystone changed the title Fixes core/tests/org.openjdk.jmc.flightrecorder.serializers.test dependency 7503: Fix serializers.test dependency Jan 12, 2022
@openjdk
Copy link

openjdk bot commented Jan 12, 2022

@bric3 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7503: Fix serializers.test dependency

Reviewed-by: hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • ce10e3f: 7482: Confusing display of stack traces when selecting event types with no events
  • b65e351: 7494: Unable to view JMC Help Contents

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@thegreystone) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@mlbridge
Copy link

mlbridge bot commented Jan 12, 2022

Webrevs

@bric3
Copy link
Collaborator Author

bric3 commented Jan 12, 2022

/integrate

@openjdk openjdk bot added the sponsor label Jan 12, 2022
@openjdk
Copy link

openjdk bot commented Jan 12, 2022

@bric3
Your change (at version 06a9c5a) is now ready to be sponsored by a Committer.

@thegreystone
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jan 12, 2022

Going to push as commit 367914b.
Since your change was applied there have been 2 commits pushed to the master branch:

  • ce10e3f: 7482: Confusing display of stack traces when selecting event types with no events
  • b65e351: 7494: Unable to view JMC Help Contents

Your commit was automatically rebased without conflicts.

@openjdk
Copy link

openjdk bot commented Jan 12, 2022

@thegreystone @bric3 Pushed as commit 367914b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@bric3 bric3 deleted the fix-flightrecorder.serializers.test-pom branch January 12, 2022 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants