Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7505: Cannot reset websocket server port to default #353

Closed
wants to merge 1 commit into from

Conversation

aptmac
Copy link
Member

@aptmac aptmac commented Jan 12, 2022

This quick change addresses JMC-7505 [0], in which the Preferences menu does not reset the value of the websocket server port.

The fix is to add the missing call to loadWebsocketPortFromPrefStore() in the performDefaults().

Before:
websocket-reset-before

After:
websocket-reset-after


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-7505: Cannot reset websocket server port to default

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/353/head:pull/353
$ git checkout pull/353

Update a local copy of the PR:
$ git checkout pull/353
$ git pull https://git.openjdk.java.net/jmc pull/353/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 353

View PR using the GUI difftool:
$ git pr show -t 353

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/353.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 12, 2022

👋 Welcome back aptmac! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jan 12, 2022
@mlbridge
Copy link

mlbridge bot commented Jan 12, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 12, 2022

@aptmac This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7505: Cannot reset websocket server port to default

Reviewed-by: hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • be067ab: 7504: Fix flightrecorder.writer.test project setup

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jan 12, 2022
@aptmac
Copy link
Member Author

aptmac commented Jan 12, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jan 12, 2022

Going to push as commit 70aa834.
Since your change was applied there has been 1 commit pushed to the master branch:

  • be067ab: 7504: Fix flightrecorder.writer.test project setup

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Jan 12, 2022
@openjdk openjdk bot closed this Jan 12, 2022
@openjdk
Copy link

openjdk bot commented Jan 12, 2022

@aptmac Pushed as commit 70aa834.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@aptmac aptmac deleted the 7505 branch January 12, 2022 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants