7507: Fixing project setup

[thegreystone]

...and some cleanup.

---

Progress

• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JMC-7507: Fixing project setup

Reviewers

• @bric3 (no known github.com user name / role)
• Alex Macdonald (@aptmac - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/355/head:pull/355
$ git checkout pull/355

Update a local copy of the PR:
$ git checkout pull/355
$ git pull https://git.openjdk.java.net/jmc pull/355/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 355

View PR using the GUI difftool:
$ git pr show -t 355

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/355.diff

[bridgekeeper]

👋 Welcome back hirt! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 01: Full - Incremental (9cca545b)
• 00: Full (70b3981c)

[aptmac]

Duplicate entry

[aptmac]

Is there anything in the uitests that use serializers and writer?

[thegreystone]

Writer, probably not right now, but doesn't hurt. I think the serializers are used by the Websocket stuff, so added them for good measure. Was trying to figure out why it's not possible to sometimes run the UI-tests after having run the RCP app from within Eclipse. I think the conclusion was that this doesn't matter, but having all of core available shouldn't hurt.

[bric3]

On clean git repository (after a the nuclear git clean -fdx), I noticed the org.openjdk.jmc.flightrecorder.writer.test project has compile errors, unless I do a right click on the project then Maven | Update Project.... Which result in this modification.

Other project's .classpath file seem to have this classpathentry element.

diff --git i/core/tests/org.openjdk.jmc.flightrecorder.writer.test/.classpath w/core/tests/org.openjdk.jmc.flightrecorder.writer.test/.classpath
index b5527438..5de0999d 100644
--- i/core/tests/org.openjdk.jmc.flightrecorder.writer.test/.classpath
+++ w/core/tests/org.openjdk.jmc.flightrecorder.writer.test/.classpath
@@ -37,4 +37,5 @@
                        <attribute name="maven.pomderived" value="true"/>
                </attributes>
        </classpathentry>
+  <classpathentry kind="output" path="target/classes"/>
 </classpath>

[thegreystone]

You'd think it shouldn't be needed given that there is only test classes, but adding.

[openjdk]

@thegreystone This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7507: Fixing project setup

Reviewed-by: aptmac

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• 132d281: 7492: Update org.owasp.encoder to version 1.2.3
• 70aa834: 7505: Cannot reset websocket server port to default

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[thegreystone]

/integrate

[openjdk]

Going to push as commit 8ade37d.
Since your change was applied there have been 2 commits pushed to the master branch:

• 132d281: 7492: Update org.owasp.encoder to version 1.2.3
• 70aa834: 7505: Cannot reset websocket server port to default

Your commit was automatically rebased without conflicts.

[openjdk]

@thegreystone Pushed as commit 8ade37d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.