-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7512: Update lz4-java and remove the osgi bundle name override #356
Conversation
👋 Welcome back bric3! A progress list of the required criteria for merging this PR into |
db1ab07
to
77c7dda
Compare
77c7dda
to
56bb815
Compare
Webrevs
|
Hi @bric3 - got to resolve the conflicts (just accepting that the files have been deleted). |
56bb815
to
f813fef
Compare
@thegreystone Done |
f813fef
to
661c875
Compare
There is no need to force push changes. The tooling will take care of the squashing and merging automatically. It's actually easier to do the review if changes aren't force pushed. |
Noted |
core/org.openjdk.jmc.flightrecorder.rules.jdk/META-INF/MANIFEST.MF
Outdated
Show resolved
Hide resolved
@bric3 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@thegreystone) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
Hi @bric3! Please type /integrate in a comment to integrate this PR. |
/integrate |
/sponsor |
Going to push as commit 9ec05b3. |
@thegreystone @bric3 Pushed as commit 9ec05b3. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
The core library dependency decalred in maven is aligned with the one in the .target files,
1.8.0
.Also I noticed the lz4-java library has an OSGI bundle symbolic name:
lz4-java
, introduced in 1.3.0 : https://github.com/lz4/lz4-java/pull/39/files#diff-e3399fe1dc27b086e517883c6cab943edbfab64139839c965b14db8d11c8a99aR1-R4However probably due to some previous bugs this required an override, done here, but this may not be necessary anymore. Hence this PR tries to use the actual osgi name.
The change is little, and hopefully won't ripple beyond.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/356/head:pull/356
$ git checkout pull/356
Update a local copy of the PR:
$ git checkout pull/356
$ git pull https://git.openjdk.java.net/jmc pull/356/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 356
View PR using the GUI difftool:
$ git pr show -t 356
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/356.diff