-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7477: JMC8.2 does not build with eclipse 4.19 (21-03) #361
7477: JMC8.2 does not build with eclipse 4.19 (21-03) #361
Conversation
👋 Welcome back hirt! A progress list of the required criteria for merging this PR into |
That said, it doesn't build anyways, without manual modifications, so might perhaps take it. |
@thegreystone this pull request can not be integrated into git checkout 7477-remove-old-platforms
git fetch https://git.openjdk.java.net/jmc master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push |
@thegreystone This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
Something is funny with the workflow. Moving this to #367 instead, and closing this. |
This would be a change from our stated intention to support the last four releases, so we may want to hold off until 2021-03 to take this.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/361/head:pull/361
$ git checkout pull/361
Update a local copy of the PR:
$ git checkout pull/361
$ git pull https://git.openjdk.java.net/jmc pull/361/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 361
View PR using the GUI difftool:
$ git pr show -t 361
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/361.diff