Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7477: JMC8.2 does not build with eclipse 4.19 (21-03) #361

Closed

Conversation

thegreystone
Copy link
Member

@thegreystone thegreystone commented Jan 16, 2022

This would be a change from our stated intention to support the last four releases, so we may want to hold off until 2021-03 to take this.


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-7477: JMC8.2 does not build with eclipse 4.19 (21-03)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/361/head:pull/361
$ git checkout pull/361

Update a local copy of the PR:
$ git checkout pull/361
$ git pull https://git.openjdk.java.net/jmc pull/361/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 361

View PR using the GUI difftool:
$ git pr show -t 361

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/361.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 16, 2022

👋 Welcome back hirt! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@thegreystone
Copy link
Member Author

That said, it doesn't build anyways, without manual modifications, so might perhaps take it.

@openjdk openjdk bot added the rfr label Jan 16, 2022
@mlbridge
Copy link

mlbridge bot commented Jan 16, 2022

Webrevs

@thegreystone thegreystone requested review from aptmac and Gunde January 16, 2022 18:16
@thegreystone thegreystone changed the title 7477: Removing old platforms 7477: JMC8.2 does not build with eclipse 4.19 (21-03) Jan 17, 2022
@openjdk
Copy link

openjdk bot commented Jan 20, 2022

@thegreystone this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout 7477-remove-old-platforms
git fetch https://git.openjdk.java.net/jmc master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk
Copy link

openjdk bot commented Jan 20, 2022

@thegreystone This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7477: JMC8.2 does not build with eclipse 4.19 (21-03)

Reviewed-by: jpbempel, hdafgard, aptmac

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready and removed merge-conflict labels Jan 20, 2022
@thegreystone
Copy link
Member Author

Something is funny with the workflow. Moving this to #367 instead, and closing this.

@thegreystone thegreystone deleted the 7477-remove-old-platforms branch January 20, 2022 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants