Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7537: Build script assumes that Darwin always targets x86_64 #366

Closed

Conversation

parttimenerd
Copy link
Contributor

@parttimenerd parttimenerd commented Jan 20, 2022

Tested on Mac M1.


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-7537: Build script assumes that Darwin always targets x86_64

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/366/head:pull/366
$ git checkout pull/366

Update a local copy of the PR:
$ git checkout pull/366
$ git pull https://git.openjdk.java.net/jmc pull/366/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 366

View PR using the GUI difftool:
$ git pr show -t 366

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/366.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 20, 2022

👋 Welcome back parttimenerd! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jan 20, 2022
@mlbridge
Copy link

mlbridge bot commented Jan 20, 2022

Webrevs

build.sh Show resolved Hide resolved
@thegreystone thegreystone changed the title 7537: build script assumes that Darwin always targets x86_64 7537: Build script assumes that Darwin always targets x86_64 Jan 20, 2022
@reinhapa
Copy link
Member

@thegreystone should we also open an issue for the Windows build script?

@parttimenerd
Copy link
Contributor Author

my take on it: it is highly unlikely that someone is running a windows on this architecture, as it only seems to be possible inside a VM.

@thegreystone
Copy link
Member

thegreystone commented Jan 21, 2022

@omikhaltsova helped verify this!

@openjdk
Copy link

openjdk bot commented Jan 21, 2022

@parttimenerd This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7537: Build script assumes that Darwin always targets x86_64

Reviewed-by: hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • c646b14: 7477: JMC8.2 does not build with eclipse 4.19 (21-03)
  • 3f9b42d: 7531: Update jetty websocket third party

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@reinhapa, @thegreystone) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Jan 21, 2022
@openjdk
Copy link

openjdk bot commented Jan 21, 2022

@reinhapa The change author (@parttimenerd) must issue an integrate command before the integration can be sponsored.

@parttimenerd
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor label Jan 21, 2022
@openjdk
Copy link

openjdk bot commented Jan 21, 2022

@parttimenerd
Your change (at version cf2c56e) is now ready to be sponsored by a Committer.

@reinhapa
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jan 21, 2022

Going to push as commit baa6c77.
Since your change was applied there have been 2 commits pushed to the master branch:

  • c646b14: 7477: JMC8.2 does not build with eclipse 4.19 (21-03)
  • 3f9b42d: 7531: Update jetty websocket third party

Your commit was automatically rebased without conflicts.

@openjdk
Copy link

openjdk bot commented Jan 21, 2022

@reinhapa @parttimenerd Pushed as commit baa6c77.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants