Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7477: JMC8.2 does not build with eclipse 4.19 (21-03) #367

Closed

Conversation

thegreystone
Copy link
Member

@thegreystone thegreystone commented Jan 20, 2022

Something funny is happening with the workflow. Trying in a separate PR to see if it can be reproduced.


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-7477: JMC8.2 does not build with eclipse 4.19 (21-03)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/367/head:pull/367
$ git checkout pull/367

Update a local copy of the PR:
$ git checkout pull/367
$ git pull https://git.openjdk.java.net/jmc pull/367/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 367

View PR using the GUI difftool:
$ git pr show -t 367

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/367.diff

@thegreystone thegreystone requested a review from aptmac January 20, 2022 22:16
@bridgekeeper
Copy link

bridgekeeper bot commented Jan 20, 2022

👋 Welcome back hirt! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@mlbridge
Copy link

mlbridge bot commented Jan 20, 2022

Webrevs

@thegreystone thegreystone requested a review from Gunde January 21, 2022 10:56
@openjdk
Copy link

openjdk bot commented Jan 21, 2022

@thegreystone This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7477: JMC8.2 does not build with eclipse 4.19 (21-03)

Reviewed-by: aptmac

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jan 21, 2022
@thegreystone
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 21, 2022

Going to push as commit c646b14.

@openjdk openjdk bot added the integrated label Jan 21, 2022
@openjdk openjdk bot closed this Jan 21, 2022
@openjdk
Copy link

openjdk bot commented Jan 21, 2022

@thegreystone Pushed as commit c646b14.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@thegreystone thegreystone deleted the 7477-remove-old-platforms-2 branch October 16, 2022 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants