Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6661: Simplify Agent JMX tests #37

Closed
wants to merge 1 commit into from
Closed

Conversation

jessyec-s
Copy link
Contributor

@jessyec-s jessyec-s commented Jan 17, 2020

This patch simplifies mbean function calls for agent JMX tests.

The proposed solution, which is outlined in the ticket's description, was to create an mbean object by calling ManagementFactory.newPlatformMXBeanProxy(...). However this function requires the AgentControllerMBean class to be loaded by the platform class loader, which it is not. So instead I have called the JMX.newMXBeanProxy(...) directly.

Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

JMC-6661: Agent tests for the JMX API can probably be simplified

Approvers

  • Marcus Hirt (hirt - Reviewer)

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 17, 2020

👋 Welcome back jessyec-s! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@openjdk openjdk bot added the rfr label Jan 17, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 17, 2020

Webrevs

@thegreystone thegreystone self-requested a review Jan 18, 2020
@openjdk openjdk bot removed the rfr label Jan 18, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jan 18, 2020

@jessyec-s This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

6661: Simplify Agent JMX tests

Reviewed-by: hirt
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to do this manually, please merge master into your branch first.

As you are not a known OpenJDK Author, an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@thegreystone) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Jan 18, 2020
@jessyec-s
Copy link
Contributor Author

@jessyec-s jessyec-s commented Jan 20, 2020

/integrate

@openjdk openjdk bot added the sponsor label Jan 20, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jan 20, 2020

@jessyec-s
Your change (at version 646146d) is now ready to be sponsored by a Committer.

@thegreystone
Copy link
Member

@thegreystone thegreystone commented Jan 20, 2020

/sponsor

@openjdk openjdk bot closed this Jan 20, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jan 20, 2020

@thegreystone @jessyec-s The following commits have been pushed to master since your change was applied:

  • c2134e2: 6672: JavaScript formatting template

Your commit was automatically rebased without conflicts.

Pushed as commit e647a9d.

@jessyec-s jessyec-s deleted the jmc-6661 branch Jan 20, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 20, 2020

Mailing list message from Marcus Hirt on jmc-dev:

Changeset: e647a9d
Author: Jessye Coleman-Shapiro <jescolem at redhat.com>
Committer: Marcus Hirt <hirt at openjdk.org>
Date: 2020-01-20 14:15:25 +0000
URL: https://git.openjdk.java.net/jmc/commit/e647a9d1

6661: Simplify Agent JMX tests

Reviewed-by: hirt

! core/org.openjdk.jmc.agent/src/test/java/org/openjdk/jmc/agent/test/TestDefineEventProbes.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants