7540: IItemCollectionJsonSerializerTest.java might fail on Windows due to line endings

[RealCLanger]

Fix test IItemCollectionJsonSerializerTest.java

The line endings should be normalized, to avoid errors on Windows due to incompatible line ending formats.

---

Progress

• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JMC-7540: IItemCollectionJsonSerializerTest.java might fail on Windows due to line endings

Reviewers

• Marcus Hirt (@thegreystone - Reviewer) ⚠️ Review applies to 4249103

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/370/head:pull/370
$ git checkout pull/370

Update a local copy of the PR:
$ git checkout pull/370
$ git pull https://git.openjdk.java.net/jmc pull/370/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 370

View PR using the GUI difftool:
$ git pr show -t 370

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/370.diff

[bridgekeeper]

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 01: Full (b4d1e568)
• 00: Full (4249103d)

[openjdk]

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7540: IItemCollectionJsonSerializerTest.java might fail on Windows due to line endings

Reviewed-by: hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@thegreystone) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[RealCLanger]

/integrate

[openjdk]

@RealCLanger
Your change (at version b4d1e56) is now ready to be sponsored by a Committer.

[thegreystone]

/sponsor

[openjdk]

Going to push as commit 3d03643.

[openjdk]

@thegreystone @RealCLanger Pushed as commit 3d03643.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[cimi]

Sorry, I'm late to the party 🙈 I wrote this test and I'm curious what the problem was here 😃

Did this test fail for you? I don't understand how it can be different on windows since the JSON file has unix line endings and the serialiser will output unix line endings.

[RealCLanger]

Hm, it's been a while but obviously it failed for me. In the bug I've written: On Windows, the returned data from IItemCollectionJsonSerializer.toJsonString(testRecording) seems to have platform line endings. Are you sure that there should be unix line endings?

[cimi]

👍 Yup, you're right. Sorry, I didn't check StructuredWriter.java, there we are using String.format("%n"); which will output platform dependent line terminators 😃