-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7467: Only use one version of d3 #372
Conversation
👋 Welcome back hirt! A progress list of the required criteria for merging this PR into |
Webrevs
|
pom.xml line 62 d3-v5-js should be changed to d3-v6-js I guess. |
...corder.graphview/src/main/java/org/openjdk/jmc/flightrecorder/graphview/views/GraphView.java
Show resolved
Hide resolved
@thegreystone This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 6 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 7f42e4a.
Your commit was automatically rebased without conflicts. |
@thegreystone Pushed as commit 7f42e4a. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Updating v5 to v6.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/372/head:pull/372
$ git checkout pull/372
Update a local copy of the PR:
$ git checkout pull/372
$ git pull https://git.openjdk.java.net/jmc pull/372/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 372
View PR using the GUI difftool:
$ git pr show -t 372
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/372.diff