Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7467: Only use one version of d3 #372

Closed
wants to merge 2 commits into from

Conversation

thegreystone
Copy link
Member

@thegreystone thegreystone commented Jan 31, 2022

Updating v5 to v6.


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/372/head:pull/372
$ git checkout pull/372

Update a local copy of the PR:
$ git checkout pull/372
$ git pull https://git.openjdk.java.net/jmc pull/372/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 372

View PR using the GUI difftool:
$ git pr show -t 372

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/372.diff

@thegreystone thegreystone requested a review from aptmac January 31, 2022 13:33
@bridgekeeper
Copy link

bridgekeeper bot commented Jan 31, 2022

👋 Welcome back hirt! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@thegreystone thegreystone requested a review from Gunde January 31, 2022 13:33
@openjdk openjdk bot added the rfr label Jan 31, 2022
@mlbridge
Copy link

mlbridge bot commented Jan 31, 2022

Webrevs

@Suchitainf
Copy link
Collaborator

pom.xml line 62 d3-v5-js should be changed to d3-v6-js I guess.

@openjdk
Copy link

openjdk bot commented Feb 3, 2022

@thegreystone This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7467: Only use one version of d3

Reviewed-by: aptmac

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • 9ec05b3: 7512: Update lz4-java and remove the osgi bundle name override
  • 2f79156: 7421: Update Japanese translation for pages
  • 87be29c: 7417: Fix incorrect identifier in result for biased locking revocation rule
  • f3ca1b1: 7539: JDP Tests failing in VPN environments
  • 7037e74: 7541: Switch to using 2021-09 by default
  • 3d03643: 7540: IItemCollectionJsonSerializerTest.java might fail on Windows due to line endings

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 3, 2022
@thegreystone
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Feb 4, 2022

Going to push as commit 7f42e4a.
Since your change was applied there have been 6 commits pushed to the master branch:

  • 9ec05b3: 7512: Update lz4-java and remove the osgi bundle name override
  • 2f79156: 7421: Update Japanese translation for pages
  • 87be29c: 7417: Fix incorrect identifier in result for biased locking revocation rule
  • f3ca1b1: 7539: JDP Tests failing in VPN environments
  • 7037e74: 7541: Switch to using 2021-09 by default
  • 3d03643: 7540: IItemCollectionJsonSerializerTest.java might fail on Windows due to line endings

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Feb 4, 2022
@openjdk openjdk bot closed this Feb 4, 2022
@openjdk openjdk bot removed ready rfr labels Feb 4, 2022
@openjdk
Copy link

openjdk bot commented Feb 4, 2022

@thegreystone Pushed as commit 7f42e4a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@thegreystone thegreystone deleted the 7467-d3-version branch February 23, 2022 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants