-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
6792: Outline shows as not available when starting up with open recording #373
Conversation
Hi @viragpurnam, welcome to this OpenJDK project and thanks for contributing! We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user viragpurnam" as summary for the issue. If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great first PR! This issue has been open for far too long. Thanks Virag!
/covered |
Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated! |
|
@viragpurnam This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@thegreystone, @aptmac) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
@viragpurnam |
/sponsor |
@Suchitainf @viragpurnam Pushed as commit 5fd290a. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Problem: On Re-launch of JMC, previously opened JFR gets loaded and shown in JFR editor. But the outline appears blank. Workaround is to click on the JFR Editor. Please refer the attached files.
Fix: On Re-launch of JMC, setting the focus on active JFR editor. This solves the problem and outline gets displayed properly.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/373/head:pull/373
$ git checkout pull/373
Update a local copy of the PR:
$ git checkout pull/373
$ git pull https://git.openjdk.java.net/jmc pull/373/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 373
View PR using the GUI difftool:
$ git pr show -t 373
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/373.diff