Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6792: Outline shows as not available when starting up with open recording #373

Closed
wants to merge 1 commit into from

Conversation

viragpurnam
Copy link
Collaborator

@viragpurnam viragpurnam commented Feb 1, 2022

Problem: On Re-launch of JMC, previously opened JFR gets loaded and shown in JFR editor. But the outline appears blank. Workaround is to click on the JFR Editor. Please refer the attached files.

OutlineIsBlank

Fix: On Re-launch of JMC, setting the focus on active JFR editor. This solves the problem and outline gets displayed properly.

OutlineGetsDisplayed


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-6792: Outline shows as not available when starting up with open recording

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/373/head:pull/373
$ git checkout pull/373

Update a local copy of the PR:
$ git checkout pull/373
$ git pull https://git.openjdk.java.net/jmc pull/373/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 373

View PR using the GUI difftool:
$ git pr show -t 373

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/373.diff

@bridgekeeper bridgekeeper bot added the oca label Feb 1, 2022
@bridgekeeper
Copy link

bridgekeeper bot commented Feb 1, 2022

Hi @viragpurnam, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user viragpurnam" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk openjdk bot changed the title 6792: Previously opened JFR remains opened in JMC despite graceful re… 6792: Previously opened JFR remains opened in JMC despite graceful relaunch Feb 1, 2022
Copy link
Member

@thegreystone thegreystone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great first PR! This issue has been open for far too long. Thanks Virag!

@viragpurnam
Copy link
Collaborator Author

/covered

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 1, 2022

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@thegreystone thegreystone changed the title 6792: Previously opened JFR remains opened in JMC despite graceful relaunch 6792: Outline shows as not available when starting up with open recording Feb 2, 2022
@openjdk
Copy link

openjdk bot commented Feb 9, 2022

⚠️ @viragpurnam the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout 6792
$ git commit -c user.name='Preferred Full Name' --allow-empty -m 'Update full name'
$ git push

@openjdk
Copy link

openjdk bot commented Feb 9, 2022

@viragpurnam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

6792: Outline shows as not available when starting up with open recording

Reviewed-by: hirt, aptmac

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 7f42e4a: 7467: Only use one version of d3

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@thegreystone, @aptmac) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@mlbridge
Copy link

mlbridge bot commented Feb 9, 2022

Webrevs

@viragpurnam
Copy link
Collaborator Author

/integrate

@openjdk openjdk bot added the sponsor label Feb 9, 2022
@openjdk
Copy link

openjdk bot commented Feb 9, 2022

@viragpurnam
Your change (at version 110db42) is now ready to be sponsored by a Committer.

@Suchitainf
Copy link
Collaborator

/sponsor

@openjdk
Copy link

openjdk bot commented Feb 9, 2022

Going to push as commit 5fd290a.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 7f42e4a: 7467: Only use one version of d3

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Feb 9, 2022
@openjdk openjdk bot closed this Feb 9, 2022
@openjdk
Copy link

openjdk bot commented Feb 9, 2022

@Suchitainf @viragpurnam Pushed as commit 5fd290a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants