Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7486: Unable to install Eclipse IDE Plugin #377

Closed
wants to merge 1 commit into from

Conversation

viragpurnam
Copy link

@viragpurnam viragpurnam commented Feb 14, 2022

Issue: Unable to install JMC supported Eclipse IDE Plugin. Some of the dependent plugins are missing.

Fix: Added those dependent plugins in "ide feature" and also deleted one unused plugin from "flight recorder feature".

Plugins added:
"org.objectweb.asm",
"org.objectweb.asm.commons",
"org.objectweb.asm.tree",
"org.objectweb.asm.util",
"org.eclipse.jetty.webapp",
"org.eclipse.jetty.security",
"org.eclipse.jetty.server",
"org.eclipse.jetty.alpn.client",
"org.eclipse.jetty.servlet",
"org.eclipse.jetty.http",
"org.eclipse.jetty.io",
"org.eclipse.jetty.util",
"org.eclipse.jetty.xml",
"org.eclipse.jetty.websocket.core.client",
"org.eclipse.jetty.websocket.core.common",
"org.eclipse.jetty.websocket.core.server",
"org.eclipse.jetty.websocket.common",
"org.eclipse.jetty.client"

Plugin removed:
"org.eclipse.jetty.websocket.javax.server"


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-7486: Unable to install Eclipse IDE Plugin

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/377/head:pull/377
$ git checkout pull/377

Update a local copy of the PR:
$ git checkout pull/377
$ git pull https://git.openjdk.java.net/jmc pull/377/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 377

View PR using the GUI difftool:
$ git pr show -t 377

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/377.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 14, 2022

👋 Welcome back viragpurnam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Feb 14, 2022
@mlbridge
Copy link

mlbridge bot commented Feb 14, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Feb 14, 2022

⚠️ @viragpurnam the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout 7486
$ git commit -c user.name='Preferred Full Name' --allow-empty -m 'Update full name'
$ git push

@openjdk
Copy link

openjdk bot commented Feb 14, 2022

@viragpurnam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7486: Unable to install Eclipse IDE Plugin

Reviewed-by: hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@thegreystone) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Feb 14, 2022
@viragpurnam
Copy link
Author

viragpurnam commented Feb 15, 2022

/integrate

@openjdk openjdk bot added the sponsor label Feb 15, 2022
@openjdk
Copy link

openjdk bot commented Feb 15, 2022

@viragpurnam
Your change (at version b731a6b) is now ready to be sponsored by a Committer.

@Suchitainf
Copy link
Collaborator

Suchitainf commented Feb 15, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Feb 15, 2022

Going to push as commit 1844ca4.

@openjdk
Copy link

openjdk bot commented Feb 15, 2022

@Suchitainf @viragpurnam Pushed as commit 1844ca4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants