Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7561: Update to the release splash screen for JMC 8.2 #380

Closed
wants to merge 1 commit into from

Conversation

thegreystone
Copy link
Member

@thegreystone thegreystone commented Feb 19, 2022

Just updating the splash in the jmc8 branch for the 8.2 release.


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-7561: Update to the release splash screen for JMC 8.2

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/380/head:pull/380
$ git checkout pull/380

Update a local copy of the PR:
$ git checkout pull/380
$ git pull https://git.openjdk.java.net/jmc pull/380/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 380

View PR using the GUI difftool:
$ git pr show -t 380

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/380.diff

@thegreystone thegreystone requested review from aptmac and Gunde February 19, 2022 13:19
@bridgekeeper
Copy link

bridgekeeper bot commented Feb 19, 2022

👋 Welcome back hirt! A progress list of the required criteria for merging this PR into jmc8 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Feb 19, 2022
@mlbridge
Copy link

mlbridge bot commented Feb 19, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Feb 19, 2022

@thegreystone This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7561: Update to the release splash screen for JMC 8.2

Reviewed-by: hdafgard

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the jmc8 branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jmc8 branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 19, 2022
@thegreystone
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Feb 19, 2022

Going to push as commit 559f902.

@openjdk openjdk bot added the integrated label Feb 19, 2022
@openjdk openjdk bot closed this Feb 19, 2022
@openjdk
Copy link

openjdk bot commented Feb 19, 2022

@thegreystone Pushed as commit 559f902.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@thegreystone thegreystone deleted the 7561-update-splash branch February 23, 2022 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants