Skip to content

Conversation

@viragpurnam
Copy link
Contributor

@viragpurnam viragpurnam commented Mar 31, 2022

Below mentioned required plugins are missing in JMC-RCP and JMC-RCP-plug-ins launcher. Added them as an additional plugins.
org.eclipse.jetty.http (10.0.7)
org.eclipse.jetty.io (10.0.7)
org.eclipse.jetty.security (10.0.7)
org.eclipse.jetty.server (10.0.7)
org.eclipse.jetty.servlet (10.0.7)
org.eclipse.jetty.util (10.0.7)

MissingRequiredPlugins


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-7581: Missing required plugins in JMC-RCP and JMC-RCP-plug-ins launcher

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/393/head:pull/393
$ git checkout pull/393

Update a local copy of the PR:
$ git checkout pull/393
$ git pull https://git.openjdk.java.net/jmc pull/393/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 393

View PR using the GUI difftool:
$ git pr show -t 393

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/393.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 31, 2022

👋 Welcome back viragpurnam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Mar 31, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 31, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Mar 31, 2022

⚠️ @viragpurnam the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout 7581
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

@openjdk
Copy link

openjdk bot commented Mar 31, 2022

@viragpurnam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7581: Missing required plugins in JMC-RCP and JMC-RCP-plug-ins launcher

Reviewed-by: jpbempel, hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jpbempel, @thegreystone) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Mar 31, 2022
@thegreystone thegreystone self-requested a review April 1, 2022 17:26
@viragpurnam
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor label Apr 1, 2022
@openjdk
Copy link

openjdk bot commented Apr 1, 2022

@viragpurnam
Your change (at version 2240988) is now ready to be sponsored by a Committer.

@jpbempel
Copy link
Member

jpbempel commented Apr 1, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Apr 1, 2022

Going to push as commit 15da4dc.

@openjdk openjdk bot added the integrated label Apr 1, 2022
@openjdk openjdk bot closed this Apr 1, 2022
@openjdk
Copy link

openjdk bot commented Apr 1, 2022

@jpbempel @viragpurnam Pushed as commit 15da4dc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants