Skip to content

Conversation

@ecki
Copy link
Contributor

@ecki ecki commented Apr 13, 2022

The AdoptOpenJDK no longer has the latest builds.
Also use https for Links.


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 committer)

Issue

  • JMC-7794: Update the link to the adoptium download site

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/397/head:pull/397
$ git checkout pull/397

Update a local copy of the PR:
$ git checkout pull/397
$ git pull https://git.openjdk.java.net/jmc pull/397/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 397

View PR using the GUI difftool:
$ git pr show -t 397

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/397.diff

@bridgekeeper bridgekeeper bot added the oca label Apr 13, 2022
@bridgekeeper
Copy link

bridgekeeper bot commented Apr 13, 2022

Hi @ecki, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user ecki" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@thegreystone thegreystone self-requested a review April 13, 2022 23:23
@ecki
Copy link
Contributor Author

ecki commented Apr 14, 2022

/covered
Company Seeburger AG, Germany.

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 14, 2022

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@thegreystone thegreystone changed the title README.md: Update Link to Eclipse download site 7794: Update the link to the adoptium download site May 13, 2022
@openjdk
Copy link

openjdk bot commented May 13, 2022

@ecki This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7794: Update the link to the adoptium download site

Reviewed-by: hirt, clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 6aeee13: 7769: Cleanup pom and project files for JMC core
  • 4a7f20f: 7767: Fix handling of version qualifier in core plugins

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@thegreystone) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@mlbridge
Copy link

mlbridge bot commented May 13, 2022

Webrevs

@thegreystone
Copy link
Member

thegreystone commented May 16, 2022

Hi @ecki! Please type /integrate in a comment. :)

@ecki
Copy link
Contributor Author

ecki commented May 16, 2022

/integrate

@openjdk openjdk bot added the sponsor label May 16, 2022
@openjdk
Copy link

openjdk bot commented May 16, 2022

@ecki
Your change (at version f75efe5) is now ready to be sponsored by a Committer.

@ecki
Copy link
Contributor Author

ecki commented May 16, 2022

(Feel free to squash the commit, if that’s still possible)

@reinhapa
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented May 19, 2022

Going to push as commit 578b500.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 6aeee13: 7769: Cleanup pom and project files for JMC core
  • 4a7f20f: 7767: Fix handling of version qualifier in core plugins

Your commit was automatically rebased without conflicts.

@openjdk
Copy link

openjdk bot commented May 19, 2022

@reinhapa @ecki Pushed as commit 578b500.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@ecki ecki deleted the patch-1 branch May 25, 2022 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants