Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7862: Platform-definitions-2022-06.target file has space in pde version #417

Closed
wants to merge 3 commits into from

Conversation

bhopatil
Copy link
Contributor

@bhopatil bhopatil commented Jul 29, 2022


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JMC-7862: Platform-definitions-2022-06.target file has space in pde version

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc pull/417/head:pull/417
$ git checkout pull/417

Update a local copy of the PR:
$ git checkout pull/417
$ git pull https://git.openjdk.org/jmc pull/417/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 417

View PR using the GUI difftool:
$ git pr show -t 417

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/417.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 29, 2022

👋 Welcome back bhopatil! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 29, 2022

⚠️ @bhopatil This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

@bhopatil bhopatil changed the title Removed space from platform-definition-2022-06.target JMC-7862: Removed space from platform-definition-2022-06.target Jul 29, 2022
@thegreystone thegreystone changed the title JMC-7862: Removed space from platform-definition-2022-06.target 7862: Removed space from platform-definition-2022-06.target Jul 29, 2022
@openjdk openjdk bot added the rfr label Jul 29, 2022
@thegreystone thegreystone changed the title 7862: Removed space from platform-definition-2022-06.target 7862: Platform-definitions-2022-06.target file has space in pde version Jul 29, 2022
@openjdk
Copy link

openjdk bot commented Jul 29, 2022

@bhopatil This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7862: Platform-definitions-2022-06.target file has space in pde version

Reviewed-by: hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 591d7b6: 7860: Upgrade d3-flame-graph in github to 4.1.3

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@thegreystone) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Jul 29, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 29, 2022

Webrevs

@bhopatil
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor label Jul 29, 2022
@openjdk
Copy link

openjdk bot commented Jul 29, 2022

@bhopatil
Your change (at version e26a8bb) is now ready to be sponsored by a Committer.

@thegreystone
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jul 29, 2022

Going to push as commit eabb861.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 591d7b6: 7860: Upgrade d3-flame-graph in github to 4.1.3

Your commit was automatically rebased without conflicts.

@openjdk
Copy link

openjdk bot commented Jul 29, 2022

@thegreystone @bhopatil Pushed as commit eabb861.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants