-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7096: Bring back Object statistics table for heap. #420
Conversation
👋 Welcome back viragpurnam! A progress list of the required criteria for merging this PR into |
Webrevs
|
...ava/org/openjdk/jmc/flightrecorder/rules/jdk/dataproviders/ObjectStatisticsDataProvider.java
Outdated
Show resolved
Hide resolved
|
@viragpurnam This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@thegreystone) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
@viragpurnam |
/sponsor |
@Suchitainf @viragpurnam Pushed as commit c03822b. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
In the memory page, below mentioned columns have been added as per the request from customer. These columns are not visible by default. Users can select these from "Visible Columns" option. Customer wants these columns for the "Object Statistics".
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc pull/420/head:pull/420
$ git checkout pull/420
Update a local copy of the PR:
$ git checkout pull/420
$ git pull https://git.openjdk.org/jmc pull/420/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 420
View PR using the GUI difftool:
$ git pr show -t 420
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/420.diff