Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7096: Bring back Object statistics table for heap. #420

Closed
wants to merge 2 commits into from

Conversation

viragpurnam
Copy link
Collaborator

@viragpurnam viragpurnam commented Aug 23, 2022

In the memory page, below mentioned columns have been added as per the request from customer. These columns are not visible by default. Users can select these from "Visible Columns" option. Customer wants these columns for the "Object Statistics".

  • Avg Live Count
  • Avg Live Size
  • Live Instances Increase
  • Percentage of Heap

ObjectStatistics


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JMC-7096: Bring back Object statistics table for heap.

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc pull/420/head:pull/420
$ git checkout pull/420

Update a local copy of the PR:
$ git checkout pull/420
$ git pull https://git.openjdk.org/jmc pull/420/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 420

View PR using the GUI difftool:
$ git pr show -t 420

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/420.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 23, 2022

👋 Welcome back viragpurnam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Aug 23, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 23, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Aug 31, 2022

⚠️ @viragpurnam the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout 7096
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

@openjdk
Copy link

openjdk bot commented Aug 31, 2022

@viragpurnam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7096: Bring back Object statistics table for heap.

Reviewed-by: hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@thegreystone) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Aug 31, 2022
@viragpurnam
Copy link
Collaborator Author

/integrate

@openjdk openjdk bot added the sponsor label Sep 1, 2022
@openjdk
Copy link

openjdk bot commented Sep 1, 2022

@viragpurnam
Your change (at version 887bdf7) is now ready to be sponsored by a Committer.

@Suchitainf
Copy link
Collaborator

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 1, 2022

Going to push as commit c03822b.
Since your change was applied there has been 1 commit pushed to the master branch:

  • f573b72: 7874: Update thirdpartyreadme.txt file for upgraded third party libraries

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Sep 1, 2022
@openjdk openjdk bot closed this Sep 1, 2022
@openjdk
Copy link

openjdk bot commented Sep 1, 2022

@Suchitainf @viragpurnam Pushed as commit c03822b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants