-
Notifications
You must be signed in to change notification settings - Fork 200
7946: core/common.test is not running any tests #448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back clanger! A progress list of the required criteria for merging this PR into |
|
@RealCLanger This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
/integrate |
|
Going to push as commit 3d80c40.
Your commit was automatically rebased without conflicts. |
|
@RealCLanger Pushed as commit 3d80c40. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Currently, probably since the latest refactoring, the common.test project does not execute any of its tests.
Let's fix it (in pom.xml) along with some other cleanups to a few test cases.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jmc pull/448/head:pull/448$ git checkout pull/448Update a local copy of the PR:
$ git checkout pull/448$ git pull https://git.openjdk.org/jmc pull/448/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 448View PR using the GUI difftool:
$ git pr show -t 448Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/448.diff