Skip to content

Conversation

@RealCLanger
Copy link
Collaborator

@RealCLanger RealCLanger commented Oct 25, 2022

Currently, probably since the latest refactoring, the common.test project does not execute any of its tests.

Let's fix it (in pom.xml) along with some other cleanups to a few test cases.


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JMC-7946: core/common.test is not running any tests

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc pull/448/head:pull/448
$ git checkout pull/448

Update a local copy of the PR:
$ git checkout pull/448
$ git pull https://git.openjdk.org/jmc pull/448/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 448

View PR using the GUI difftool:
$ git pr show -t 448

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/448.diff

Fix project core/tests/org.openjdk.jmc.common.test to make it run tests again
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 25, 2022

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Oct 25, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 25, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 26, 2022

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7946: core/common.test is not running any tests

Reviewed-by: hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • a4ee558: 7945: Avoid throwing NoSuchFieldException in ValueReaders$ReflectiveReader
  • bd35870: 7861: Bump Agent build to Java 11 compliance and cleanup POM

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 26, 2022
@RealCLanger
Copy link
Collaborator Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 26, 2022

Going to push as commit 3d80c40.
Since your change was applied there have been 2 commits pushed to the master branch:

  • a4ee558: 7945: Avoid throwing NoSuchFieldException in ValueReaders$ReflectiveReader
  • bd35870: 7861: Bump Agent build to Java 11 compliance and cleanup POM

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Oct 26, 2022
@openjdk openjdk bot closed this Oct 26, 2022
@openjdk
Copy link

openjdk bot commented Oct 26, 2022

@RealCLanger Pushed as commit 3d80c40.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RealCLanger RealCLanger deleted the 7946 branch October 26, 2022 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants