Skip to content

Conversation

@jpbempel
Copy link
Member

@jpbempel jpbempel commented Nov 16, 2022

Change min to max attribute


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JMC-7977: Maximum Young Gen Size is displaying the min in GC config Page

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc pull/452/head:pull/452
$ git checkout pull/452

Update a local copy of the PR:
$ git checkout pull/452
$ git pull https://git.openjdk.org/jmc pull/452/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 452

View PR using the GUI difftool:
$ git pr show -t 452

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/452.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 16, 2022

👋 Welcome back jpbempel! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Nov 16, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 16, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Nov 16, 2022

@jpbempel This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7977: Maximum Young Gen Size is displaying the min in GC config Page

Reviewed-by: aptmac

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 16, 2022
@jpbempel
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 18, 2022

Going to push as commit 9ba238e.

@openjdk openjdk bot added the integrated label Nov 18, 2022
@openjdk openjdk bot closed this Nov 18, 2022
@openjdk
Copy link

openjdk bot commented Nov 18, 2022

@jpbempel Pushed as commit 9ba238e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants