Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8041: JfrRulesReport -format json produce incomplete results #468

Closed
wants to merge 1 commit into from

Conversation

Suchitainf
Copy link
Collaborator

@Suchitainf Suchitainf commented Feb 22, 2023

The output of JSON report contains blank placeholders like below:
"message": "",
"detailedMessage": ""

After the fix:

"message": "No long socket write pauses were found in this recording (the longest was 26.678 ms).",
"detailedMessage": "Note that there are some socket write patterns with high duration writes that we consider to be normal and are therefore excluded. Such patterns include JMX RMI communication."


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JMC-8041: JfrRulesReport -format json produce incomplete results

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc pull/468/head:pull/468
$ git checkout pull/468

Update a local copy of the PR:
$ git checkout pull/468
$ git pull https://git.openjdk.org/jmc pull/468/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 468

View PR using the GUI difftool:
$ git pr show -t 468

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/468.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 22, 2023

👋 Welcome back schaturvedi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Feb 22, 2023
@mlbridge
Copy link

mlbridge bot commented Feb 22, 2023

Webrevs

Copy link
Collaborator

@RealCLanger RealCLanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk
Copy link

openjdk bot commented Feb 24, 2023

@Suchitainf This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8041: JfrRulesReport -format json produce incomplete results

Reviewed-by: clanger, hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 456da39: 7951: Factor out commonly used test helper classes from org.openjdk.jmc.common.test into dedicated test library module
  • 8eb9115: 8036: Upgrading Jakarta Mail in JMC

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 24, 2023
@Suchitainf
Copy link
Collaborator Author

/integrate

@openjdk
Copy link

openjdk bot commented Feb 26, 2023

Going to push as commit dd11789.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 456da39: 7951: Factor out commonly used test helper classes from org.openjdk.jmc.common.test into dedicated test library module
  • 8eb9115: 8036: Upgrading Jakarta Mail in JMC

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Feb 26, 2023
@openjdk openjdk bot closed this Feb 26, 2023
@openjdk
Copy link

openjdk bot commented Feb 26, 2023

@Suchitainf Pushed as commit dd11789.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants