-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8041: JfrRulesReport -format json produce incomplete results #468
Conversation
👋 Welcome back schaturvedi! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Suchitainf This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit dd11789.
Your commit was automatically rebased without conflicts. |
@Suchitainf Pushed as commit dd11789. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
The output of JSON report contains blank placeholders like below:
"message": "",
"detailedMessage": ""
After the fix:
"message": "No long socket write pauses were found in this recording (the longest was 26.678 ms).",
"detailedMessage": "Note that there are some socket write patterns with high duration writes that we consider to be normal and are therefore excluded. Such patterns include JMX RMI communication."
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc pull/468/head:pull/468
$ git checkout pull/468
Update a local copy of the PR:
$ git checkout pull/468
$ git pull https://git.openjdk.org/jmc pull/468/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 468
View PR using the GUI difftool:
$ git pr show -t 468
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/468.diff