Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6685: Parse more fields directly to primitive values #47

Closed
wants to merge 2 commits into from

Conversation

@Gunde
Copy link
Collaborator

@Gunde Gunde commented Feb 7, 2020

Currently the parser reads line numbers, byte code indexes, modifiers and java thread ids with a QuantityReader, while as soon as they're used converted into primitive values. This PR changes the parser to read those field values as primitives directly.

Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

JMC-6685: Read primitives in parser when possible

Approvers

  • Marcus Hirt (hirt - Reviewer)
Gunde added 2 commits Feb 7, 2020
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 7, 2020

👋 Welcome back hdafgard! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@Gunde Gunde requested a review from thegreystone Feb 7, 2020
@openjdk openjdk bot added the rfr label Feb 7, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 7, 2020

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Feb 10, 2020

@Gunde This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

6685: Parse more fields directly to primitive values

Reviewed-by: hirt
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 10, 2020
@Gunde
Copy link
Collaborator Author

@Gunde Gunde commented Feb 10, 2020

/integrate

@openjdk openjdk bot closed this Feb 10, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 10, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Feb 10, 2020

@Gunde
Pushed as commit c85d31b.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 10, 2020

Mailing list message from Henrik Dafgård on jmc-dev:

Changeset: c85d31b
Author: Henrik Dafg?rd <hdafgard at openjdk.org>
Date: 2020-02-10 15:26:17 +0000
URL: https://git.openjdk.java.net/jmc/commit/c85d31b0

6685: Parse more fields directly to primitive values

Reviewed-by: hirt

! core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/internal/parser/v1/StructTypes.java
! core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/internal/parser/v1/TypeManager.java
! core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/internal/util/JfrInternalConstants.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants