Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8063: IMCFrame Type cache not synchronized #476

Closed
wants to merge 1 commit into from

Conversation

PyvesB
Copy link
Contributor

@PyvesB PyvesB commented Apr 6, 2023

The type cache used in the IMCFrame Type inner class isn't synchronized and can thus cause a concurrent modification exception during e.g. JFR parsing.


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JMC-8063: IMCFrame Type cache not synchronized

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/476/head:pull/476
$ git checkout pull/476

Update a local copy of the PR:
$ git checkout pull/476
$ git pull https://git.openjdk.org/jmc.git pull/476/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 476

View PR using the GUI difftool:
$ git pr show -t 476

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/476.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 6, 2023

👋 Welcome back PyvesB! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Apr 6, 2023
Copy link
Collaborator

@Gunde Gunde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@openjdk
Copy link

openjdk bot commented Apr 6, 2023

@PyvesB This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8063: IMCFrame Type cache not synchronized

Reviewed-by: hdafgard

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@Gunde) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Apr 6, 2023
@mlbridge
Copy link

mlbridge bot commented Apr 6, 2023

Webrevs

@PyvesB
Copy link
Contributor Author

PyvesB commented Apr 11, 2023

/integrate

@openjdk openjdk bot added the sponsor label Apr 11, 2023
@openjdk
Copy link

openjdk bot commented Apr 11, 2023

@PyvesB
Your change (at version 2cffe70) is now ready to be sponsored by a Committer.

@thegreystone
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Apr 11, 2023

Going to push as commit 8c0d129.

@openjdk
Copy link

openjdk bot commented Apr 11, 2023

@thegreystone @PyvesB Pushed as commit 8c0d129.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants