Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8065: Remove socket read illegal value #478

Closed
wants to merge 4 commits into from
Closed

Conversation

xpbob
Copy link

@xpbob xpbob commented Apr 13, 2023

图片

Socket read failure returns -1
Negative statistics affect accuracy

After modification
图片


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JMC-8065: Remove socket read illegal value

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/478/head:pull/478
$ git checkout pull/478

Update a local copy of the PR:
$ git checkout pull/478
$ git pull https://git.openjdk.org/jmc.git pull/478/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 478

View PR using the GUI difftool:
$ git pr show -t 478

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/478.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 13, 2023

👋 Welcome back xpbob! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Apr 13, 2023
@mlbridge
Copy link

mlbridge bot commented Apr 13, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Apr 24, 2023

@xpbob This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8065: Remove socket read illegal value

Reviewed-by: hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 06bbd5f: 8057: Upgrade to 2023-03
  • 7d88877: 8067: JMC Automated Analysis Page shows blank
  • 1fb69d4: 8046: build.bat --packageAgent doesn't detect failed builds

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@thegreystone) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Apr 24, 2023
SumConsumer(IMemberAccessor<? extends IQuantity, IItem> accessor) {
super(accessor);
}

SumConsumer(IMemberAccessor<? extends IQuantity, IItem> accessor, Predicate predicate) {
super(accessor);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I think I'd prefer this as this(accessor).

@thegreystone
Copy link
Member

Thanks for the contribution! 👍

@xpbob
Copy link
Author

xpbob commented Apr 25, 2023

@thegreystone Thanks for the review

@xpbob
Copy link
Author

xpbob commented Apr 25, 2023

/integrate

@openjdk openjdk bot added the sponsor label Apr 25, 2023
@openjdk
Copy link

openjdk bot commented Apr 25, 2023

@xpbob
Your change (at version 7cbf73c) is now ready to be sponsored by a Committer.

@openjdk openjdk bot removed the sponsor label Apr 25, 2023
@xpbob
Copy link
Author

xpbob commented Apr 25, 2023

The code has been updated

@thegreystone
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Apr 25, 2023

@thegreystone The PR has been updated since the change author (@xpbob) issued the integrate command - the author must perform this command again.

@thegreystone
Copy link
Member

Hi @xpbob! Please /integrate again.

@xpbob
Copy link
Author

xpbob commented Apr 26, 2023

/integrate

@openjdk openjdk bot added the sponsor label Apr 26, 2023
@openjdk
Copy link

openjdk bot commented Apr 26, 2023

@xpbob
Your change (at version 8cc9d1c) is now ready to be sponsored by a Committer.

@xpbob
Copy link
Author

xpbob commented Apr 26, 2023

Hi @thegreystone
Thanks for the review
I add tag /integrate

@RealCLanger
Copy link
Collaborator

/sponsor

@openjdk
Copy link

openjdk bot commented Apr 26, 2023

Going to push as commit 58c9ede.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 06bbd5f: 8057: Upgrade to 2023-03
  • 7d88877: 8067: JMC Automated Analysis Page shows blank
  • 1fb69d4: 8046: build.bat --packageAgent doesn't detect failed builds

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Apr 26, 2023
@openjdk openjdk bot closed this Apr 26, 2023
@openjdk openjdk bot removed the ready label Apr 26, 2023
@openjdk
Copy link

openjdk bot commented Apr 26, 2023

@RealCLanger @xpbob Pushed as commit 58c9ede.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants