-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8075: Improve Eclipse development experience #489
Conversation
👋 Welcome back clanger! A progress list of the required criteria for merging this PR into |
a13814e
to
c77959d
Compare
@RealCLanger Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just caught one typo
@RealCLanger This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
Thanks for the review. /integrate |
Going to push as commit 36c5d7d. |
@RealCLanger Pushed as commit 36c5d7d. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This PR merely updates the .classpath files to the state they would end up in when you do
Maven -> Update project ...
in current Eclipse.There were only 2 manual changes:
--release
compiler option.In addition to that, I polished the devguide a little bit to hopefully make it more clear and stringent.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/489/head:pull/489
$ git checkout pull/489
Update a local copy of the PR:
$ git checkout pull/489
$ git pull https://git.openjdk.org/jmc.git pull/489/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 489
View PR using the GUI difftool:
$ git pr show -t 489
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/489.diff
Webrev
Link to Webrev Comment