Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8075: Improve Eclipse development experience #489

Closed
wants to merge 2 commits into from

Conversation

RealCLanger
Copy link
Collaborator

@RealCLanger RealCLanger commented May 26, 2023

This PR merely updates the .classpath files to the state they would end up in when you do Maven -> Update project ... in current Eclipse.

There were only 2 manual changes:

  1. I updated/corrected application/org.openjdk.jmc.flightrecorder.dependencyview/build.properties
  2. I removed application/org.openjdk.jmc.browser.attach/.settings/org.eclipse.jdt.core.prefs because it gets generated upon Eclipse import anyway. Unfortunately it does not serve the use as a workaround for deselecting the --release compiler option.

In addition to that, I polished the devguide a little bit to hopefully make it more clear and stringent.


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JMC-8075: Improve Eclipse development experience

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/489/head:pull/489
$ git checkout pull/489

Update a local copy of the PR:
$ git checkout pull/489
$ git pull https://git.openjdk.org/jmc.git pull/489/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 489

View PR using the GUI difftool:
$ git pr show -t 489

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/489.diff

Webrev

Link to Webrev Comment

Improve Eclipse development experience

Update some .classpath files
Polish the devguide
Remove application/org.openjdk.jmc.browser.attach/.settings/org.eclipse.jdt.core.prefs
@bridgekeeper
Copy link

bridgekeeper bot commented May 26, 2023

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 26, 2023

@RealCLanger Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@openjdk openjdk bot added the rfr label May 26, 2023
@mlbridge
Copy link

mlbridge bot commented May 26, 2023

Webrevs

Copy link
Member

@aptmac aptmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just caught one typo

docs/devguide/README.md Outdated Show resolved Hide resolved
@openjdk
Copy link

openjdk bot commented May 30, 2023

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8075: Improve Eclipse development experience

Reviewed-by: aptmac

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label May 30, 2023
@RealCLanger
Copy link
Collaborator Author

Thanks for the review.

/integrate

@openjdk
Copy link

openjdk bot commented May 30, 2023

Going to push as commit 36c5d7d.

@openjdk openjdk bot added the integrated label May 30, 2023
@openjdk openjdk bot closed this May 30, 2023
@openjdk
Copy link

openjdk bot commented May 30, 2023

@RealCLanger Pushed as commit 36c5d7d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RealCLanger RealCLanger deleted the eclipse-experience branch May 30, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants