Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8091: Refactoring for jmc/application #497

Closed
wants to merge 3 commits into from

Conversation

RealCLanger
Copy link
Collaborator

@RealCLanger RealCLanger commented Jun 14, 2023

The sibling PR to #495 for the non-core project.

It cleans up the pom, bumping some versions and fixing URLs.
The integration for spotless and checkstyle is cleaner now, allowing to build projects from subdirectories.
spotless is called as part of the main build lifecycle now.


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JMC-8091: Refactoring for jmc/application (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/497/head:pull/497
$ git checkout pull/497

Update a local copy of the PR:
$ git checkout pull/497
$ git pull https://git.openjdk.org/jmc.git pull/497/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 497

View PR using the GUI difftool:
$ git pr show -t 497

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/497.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 14, 2023

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jun 14, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 14, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Jun 15, 2023

@RealCLanger Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@openjdk
Copy link

openjdk bot commented Jun 20, 2023

@RealCLanger Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@RealCLanger
Copy link
Collaborator Author

I think this one is ready for review now. It touches a lot of files which are merely the pom.xml's, converting from spotless.config.path to the more generic jmc.config.path. Particularly interesting is probably only the main pom.xml where the real modifications happen.

@openjdk
Copy link

openjdk bot commented Jun 22, 2023

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8091: Refactoring for jmc/application

Reviewed-by: aptmac

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 3d7614c: 8095: Update org.openjdk.jmc.flightrecorder.rules.test/.classpath after JMC-8086

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@RealCLanger
Copy link
Collaborator Author

Thanks for the review.

/integrate

@openjdk
Copy link

openjdk bot commented Jun 29, 2023

Going to push as commit af306fa.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 5ace151: 8096: EventTemplateTest fails for JDKs with custom jfr profiles
  • 3d7614c: 8095: Update org.openjdk.jmc.flightrecorder.rules.test/.classpath after JMC-8086

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Jun 29, 2023
@openjdk openjdk bot closed this Jun 29, 2023
@openjdk
Copy link

openjdk bot commented Jun 29, 2023

@RealCLanger Pushed as commit af306fa.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RealCLanger RealCLanger deleted the JMC-8091 branch June 29, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants