Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8097: Fix project setup of uitests/org.openjdk.jmc.test.jemmy #503

Closed
wants to merge 2 commits into from

Conversation

RealCLanger
Copy link
Collaborator

@RealCLanger RealCLanger commented Jun 29, 2023

The project uitests/org.openjdk.jmc.test.jemmy is a plugin project which is a helper library for other uitests.

Currently, the sources reside in the src/test/java folder and the eclipse configuration would also place the compiled classes in target/test-classes.
When one does a plain maven build, without Eclipse involvement or using the clean target, everything works fine since then the compiled classes are generated into target/classes despite their source location.
However, building the project in Eclipse generates the classes in target/test-classes and this will cause the surefire plugin to pick up some classes as potential tests when running mvn verify thereafter. Since the test.jemmy project is not configured for launching a test runtime, we see bundle resolver failures.

I fix this by moving the source files from src/test to src/main and fixing the Eclipse configuration files. I also removed the target-platform-configuration section from the pom.xml since it is redundant (already inherited by a parent pom).


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JMC-8097: Fix project setup of uitests/org.openjdk.jmc.test.jemmy (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/503/head:pull/503
$ git checkout pull/503

Update a local copy of the PR:
$ git checkout pull/503
$ git pull https://git.openjdk.org/jmc.git pull/503/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 503

View PR using the GUI difftool:
$ git pr show -t 503

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/503.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 29, 2023

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@mlbridge
Copy link

mlbridge bot commented Jun 29, 2023

Webrevs

Copy link
Member

@aptmac aptmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for taking a look into this

@openjdk
Copy link

openjdk bot commented Jun 29, 2023

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8097: Fix project setup of uitests/org.openjdk.jmc.test.jemmy

Reviewed-by: aptmac

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 29, 2023
@RealCLanger
Copy link
Collaborator Author

Thanks for the review. Please let me know if there are still issues with uitests setup.

/integrate

@openjdk
Copy link

openjdk bot commented Jun 30, 2023

Going to push as commit c98397e.

@openjdk openjdk bot added the integrated label Jun 30, 2023
@openjdk openjdk bot closed this Jun 30, 2023
@openjdk
Copy link

openjdk bot commented Jun 30, 2023

@RealCLanger Pushed as commit c98397e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RealCLanger RealCLanger deleted the jemmy branch June 30, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants