7441: JVM System information tables do not scroll horizontally

[aptmac]

This PR addresses JMC-7441 [0], in which the tables on the System tab in the JVM Browser don't scroll horizontally (very well).

While looking into this I noticed it affects many more tables, potentially most notable would be the automated analysis report ui, but that should be taken care of in a separate ticket.

The problem is that the column sizes aren't being set appropriately to the contents of the table. This affects the tables initialized with SWT.VIRTUAL, because these are lazy loaded and are not always fully filled out when it's time for the table to paint. I was playing around with an idea of adding a listener on the SWT.Paint event and having the columns re-sized in an attempt to keep these as virtual tables, but the initial re-paint was jarring visually. Also it might not make sense for (some of) these tables to be virtual; they don't contain a large amount of information and/or aren't mutable.

For the sake of the JVM Browser System tab tables, I just made these tables non-virtual and added a column packing function to the ColumnManager. The result is now the entire contents can be viewed in the table.

[0] https://bugs.openjdk.org/browse/JMC-7441

---

Progress

• Commit message must refer to an issue
• Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

• JMC-7441: JVM System information tables do not scroll horizontally (Bug - P4)

Reviewers

• Marcus Hirt (@thegreystone - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/505/head:pull/505
$ git checkout pull/505

Update a local copy of the PR:
$ git checkout pull/505
$ git pull https://git.openjdk.org/jmc.git pull/505/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 505

View PR using the GUI difftool:
$ git pr show -t 505

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/505.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back aptmac! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 00: Full (c1e5c37d)

[openjdk]

@aptmac This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7441: JVM System information tables do not scroll horizontally

Reviewed-by: hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[aptmac]

/integrate

[openjdk]

Going to push as commit eceb279.

[openjdk]

@aptmac Pushed as commit eceb279.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.