-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8101: Add ignore icon to automated analysis table #506
Conversation
👋 Welcome back aptmac! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
@aptmac This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 952fb0d. |
This short PR addresses JMC-8108 [0], in which there is no icon for "Ignore" rules in the automated analysis page table. Here there's just a new case added to the switch statement that assigns icons for the table.
Before:
After:
[0] https://bugs.openjdk.org/browse/JMC-8101
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/506/head:pull/506
$ git checkout pull/506
Update a local copy of the PR:
$ git checkout pull/506
$ git pull https://git.openjdk.org/jmc.git pull/506/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 506
View PR using the GUI difftool:
$ git pr show -t 506
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/506.diff
Webrev
Link to Webrev Comment