Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8101: Add ignore icon to automated analysis table #506

Closed
wants to merge 1 commit into from

Conversation

aptmac
Copy link
Member

@aptmac aptmac commented Jul 14, 2023

This short PR addresses JMC-8108 [0], in which there is no icon for "Ignore" rules in the automated analysis page table. Here there's just a new case added to the switch statement that assigns icons for the table.

Before:
Screenshot from 2023-07-13 16-57-04

After:
Screenshot from 2023-07-13 23-03-55

[0] https://bugs.openjdk.org/browse/JMC-8101


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JMC-8101: Add ignore icon to automated analysis table (Enhancement - P5)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/506/head:pull/506
$ git checkout pull/506

Update a local copy of the PR:
$ git checkout pull/506
$ git pull https://git.openjdk.org/jmc.git pull/506/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 506

View PR using the GUI difftool:
$ git pr show -t 506

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/506.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 14, 2023

👋 Welcome back aptmac! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jul 14, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 14, 2023

Webrevs

Copy link
Collaborator

@Suchitainf Suchitainf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@openjdk
Copy link

openjdk bot commented Jul 14, 2023

@aptmac This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8101: Add ignore icon to automated analysis table

Reviewed-by: schaturvedi, vpurnam

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jul 14, 2023
@aptmac
Copy link
Member Author

aptmac commented Jul 15, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jul 15, 2023

Going to push as commit 952fb0d.

@openjdk openjdk bot added the integrated label Jul 15, 2023
@openjdk openjdk bot closed this Jul 15, 2023
@openjdk
Copy link

openjdk bot commented Jul 15, 2023

@aptmac Pushed as commit 952fb0d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@aptmac aptmac deleted the add-ignore-icon branch July 15, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants