Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6693: Eclipse projects core/org.openjdk.jmc.jdp* should have the correct JRE target level #51

Closed
wants to merge 1 commit into from

Conversation

RealCLanger
Copy link
Collaborator

@RealCLanger RealCLanger commented Feb 13, 2020

Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

JMC-6693: Eclipse projects core/org.openjdk.jmc.jdp* should have the correct JRE target level

Approvers

  • Marcus Hirt (hirt - Reviewer)

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 13, 2020

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label Feb 13, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 13, 2020

Webrevs

Copy link
Member

@thegreystone thegreystone left a comment

This is fine, though temporary - we will likely move all of core up to 8 soon enough. ;)

@openjdk
Copy link

@openjdk openjdk bot commented Feb 13, 2020

@RealCLanger This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

6693: Eclipse projects core/org.openjdk.jmc.jdp* should have the correct JRE target level

Reviewed-by: hirt
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate ec4630f8df7a2c49d7b1e2af30bacdbc4f96db46.

As you do not have Committer status in this project, an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@thegreystone) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Feb 13, 2020
@RealCLanger
Copy link
Collaborator Author

@RealCLanger RealCLanger commented Feb 13, 2020

This is fine, though temporary - we will likely move all of core up to 8 soon enough. ;)

I know... but with skara it's so easy to get even such minor changes done :) Thx for the review.

@RealCLanger
Copy link
Collaborator Author

@RealCLanger RealCLanger commented Feb 13, 2020

/integrate

@openjdk openjdk bot added the sponsor label Feb 13, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Feb 13, 2020

@RealCLanger
Your change (at version 3bcf45f) is now ready to be sponsored by a Committer.

@thegreystone
Copy link
Member

@thegreystone thegreystone commented Feb 13, 2020

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Feb 13, 2020

@thegreystone @RealCLanger The following commits have been pushed to master since your change was applied:

  • ec4630f: 6687: Add icon to the flame view to render as icicle graph

Your commit was automatically rebased without conflicts.

Pushed as commit ef91b05.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 13, 2020

Mailing list message from Marcus Hirt on jmc-dev:

Changeset: ef91b05
Author: Christoph Langer <clanger at openjdk.org>
Committer: Marcus Hirt <hirt at openjdk.org>
Date: 2020-02-13 14:12:03 +0000
URL: https://git.openjdk.java.net/jmc/commit/ef91b057

6693: Eclipse projects core/org.openjdk.jmc.jdp* should have the correct JRE target level

Reviewed-by: hirt

! core/org.openjdk.jmc.jdp/.classpath
! core/tests/org.openjdk.jmc.jdp.test/.classpath

@RealCLanger RealCLanger deleted the 6693 branch Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants