-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8154: Some JMX attributes are missing unit specifications in the Console #536
Conversation
👋 Welcome back hirt! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@thegreystone This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
/integrate |
@thegreystone Pushed as commit 3cf45bb. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
I also noticed that TotalPhysicalMemorySize had been deprecated. I'll keep using it though, so that the console will keep working with pre-JDK 14 versions of the JDK.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/536/head:pull/536
$ git checkout pull/536
Update a local copy of the PR:
$ git checkout pull/536
$ git pull https://git.openjdk.org/jmc.git pull/536/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 536
View PR using the GUI difftool:
$ git pr show -t 536
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/536.diff
Webrev
Link to Webrev Comment