Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8167: [Accessibility]: 'Click here to start using JDK Mission Control' button does not have any function to open JDK mission control #547

Closed
wants to merge 1 commit into from

Conversation

Suchitainf
Copy link
Contributor

@Suchitainf Suchitainf commented Jan 25, 2024

On Welcome page, User move focus to "Click here to start using JDK Mission Control" button and press Enter but it does not have any function to open JDK mission control.

This issue was reported as part of accessibility testing requirement. From the accessibility point of view, the user will be stuck on welcome page and won't be able to proceed further.

image

Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JMC-8167: [Accessibility]: 'Click here to start using JDK Mission Control' button does not have any function to open JDK mission control (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/547/head:pull/547
$ git checkout pull/547

Update a local copy of the PR:
$ git checkout pull/547
$ git pull https://git.openjdk.org/jmc.git pull/547/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 547

View PR using the GUI difftool:
$ git pr show -t 547

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/547.diff

Webrev

Link to Webrev Comment

…' button does not have any function to open JDK mission control
@bridgekeeper
Copy link

bridgekeeper bot commented Jan 25, 2024

👋 Welcome back schaturvedi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jan 25, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 25, 2024

Webrevs

@aptmac
Copy link
Member

aptmac commented Jan 25, 2024

I tried out this PR and it looks to work, but I also opened up jmc 8.3.0 and it also worked. It looks like there's two elements in the area of this button, and hitting enter only works if it's on the later of the two. See below:

I have opened the welcome page and hit "tab" until I start focusing the html components. Once I get closer to the button, there are two components that can be focused, but only the last one works:

Hitting enter on this focused element does nothing:
Screenshot from 2024-01-25 09-47-18

Hitting enter on this element is what works:
Screenshot from 2024-01-25 09-47-21

Edit: thinking a bit more .. could this inconsistency be due to the SWT browser? I tested this on Linux, what OS did you write this patch against? If this PR is what makes the enter key work for a specific browser then that'd be a good improvement.

@Suchitainf
Copy link
Contributor Author

@aptmac Thanks for the review. The issue was raised for Windows and Mac. I have written and tested on windows.

Copy link
Member

@aptmac aptmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave this a try on Windows and it works.

Currently, the Windows version is similar to what I have in my screenshots for the Linux version in comment: #547 (comment). When cycling through the html components with tab, there are two components in the area of the button. The first one encapsulates the whole button, and does not work when enter is hit. The second one in Linux is shifted downwards a bit, and in Windows does not show highlighting at all (even though it is still selected), and both will proceed when hitting enter on the keyboard. While this PR does a nice job to tie the expected behaviour to the button it might be worthwhile to take a better look at the html and figure out what's going on with the components.

@openjdk
Copy link

openjdk bot commented Jan 29, 2024

@Suchitainf This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8167: [Accessibility]: 'Click here to start using JDK Mission Control' button does not have any function to open JDK mission control

Reviewed-by: aptmac

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jan 29, 2024
@Suchitainf
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 29, 2024

Going to push as commit 8f9ffb3.

@openjdk openjdk bot added the integrated label Jan 29, 2024
@openjdk openjdk bot closed this Jan 29, 2024
@openjdk
Copy link

openjdk bot commented Jan 29, 2024

@Suchitainf Pushed as commit 8f9ffb3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants