Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7263: JMC displaying long value in scientific notation #559

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Suchitainf
Copy link
Contributor

@Suchitainf Suchitainf commented Apr 1, 2024

This PR addresses the formatting issue for the certificate Ids for X509 Certificate events.

Before the fix:
image (3)

After the fix:
Screenshot 2024-04-01 222303


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JMC-7263: JMC displaying long value in scientific notation (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/559/head:pull/559
$ git checkout pull/559

Update a local copy of the PR:
$ git checkout pull/559
$ git pull https://git.openjdk.org/jmc.git pull/559/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 559

View PR using the GUI difftool:
$ git pr show -t 559

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/559.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 1, 2024

👋 Welcome back schaturvedi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 1, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr label Apr 1, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 1, 2024

Webrevs

@@ -44,4 +44,5 @@ public final class JfrInternalConstants {
public static final String BCI_ID = "bytecodeIndex"; //$NON-NLS-1$
public static final String MODIFIERS_ID = "modifiers"; //$NON-NLS-1$
public static final String JAVA_THREAD_ID_ID = "javaThreadId"; //$NON-NLS-1$
public static final String CERTIFICATE_ID = "certificateId"; //$NON-NLS-1$
Copy link
Member

@e1iu e1iu Apr 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about CERTIFICATED_ID_ID ?

@bridgekeeper
Copy link

bridgekeeper bot commented May 2, 2024

@Suchitainf This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 participants