Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7263: JMC displaying long value in scientific notation #564

Closed
wants to merge 1 commit into from

Conversation

Suchitainf
Copy link
Contributor

@Suchitainf Suchitainf commented May 25, 2024

This PR addresses the formatting issue for the certificate Ids for X509 Certificate and X509 Validation events.


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JMC-7263: JMC displaying long value in scientific notation (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/564/head:pull/564
$ git checkout pull/564

Update a local copy of the PR:
$ git checkout pull/564
$ git pull https://git.openjdk.org/jmc.git pull/564/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 564

View PR using the GUI difftool:
$ git pr show -t 564

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/564.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 25, 2024

👋 Welcome back schaturvedi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 25, 2024

@Suchitainf This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7263: JMC displaying long value in scientific notation

Reviewed-by: vpurnam, hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr label May 25, 2024
@mlbridge
Copy link

mlbridge bot commented May 25, 2024

Webrevs

@openjdk openjdk bot added the ready label May 27, 2024
@Suchitainf
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented May 28, 2024

Going to push as commit ad0ef9e.

@openjdk openjdk bot added the integrated label May 28, 2024
@openjdk openjdk bot closed this May 28, 2024
@openjdk
Copy link

openjdk bot commented May 28, 2024

@Suchitainf Pushed as commit ad0ef9e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants