Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8114: Verify fixed uitests in ControlRecordingsTest on jdk 17 #575

Closed
wants to merge 1 commit into from

Conversation

aptmac
Copy link
Member

@aptmac aptmac commented Jul 30, 2024

JMC-8114 (https://bugs.openjdk.org/browse/JMC-8114) is a follow-up to JMC-8175 (https://bugs.openjdk.org/browse/JMC-8175).

There were a handful of uitests in ControlRecordingsTest that were failing, and were ignored until this backport was released in 17.0.12: https://bugs.openjdk.org/browse/JDK-8328159.

They're passing again now, so the tests can be un-ignored and run again.

Having said that, I'm running into different flightrecorder uitest failures now, but can address that in a different issue.


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JMC-8114: Verify fixed uitests in ControlRecordingsTest on jdk 17 (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/575/head:pull/575
$ git checkout pull/575

Update a local copy of the PR:
$ git checkout pull/575
$ git pull https://git.openjdk.org/jmc.git pull/575/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 575

View PR using the GUI difftool:
$ git pr show -t 575

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/575.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 30, 2024

👋 Welcome back aptmac! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 30, 2024

@aptmac This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8114: Verify fixed uitests in ControlRecordingsTest on jdk 17

Reviewed-by: vpurnam, hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 4c9d9e4: 7992: Add API to easily write annotated Java JFR events
  • 5016cc1: 8245: Improve XML processing
  • 8a04432: 8236: Add support for Jolokia discovery

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr label Jul 30, 2024
@mlbridge
Copy link

mlbridge bot commented Jul 30, 2024

Webrevs

@openjdk openjdk bot added the ready label Aug 2, 2024
@aptmac
Copy link
Member Author

aptmac commented Aug 26, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Aug 26, 2024

Going to push as commit 719b714.
Since your change was applied there have been 4 commits pushed to the master branch:

  • ab0f9a6: 8244: Turn off scientific notation in JMC for attributes with long data type
  • 4c9d9e4: 7992: Add API to easily write annotated Java JFR events
  • 5016cc1: 8245: Improve XML processing
  • 8a04432: 8236: Add support for Jolokia discovery

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Aug 26, 2024
@openjdk openjdk bot closed this Aug 26, 2024
@openjdk
Copy link

openjdk bot commented Aug 26, 2024

@aptmac Pushed as commit 719b714.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@aptmac aptmac deleted the 8114 branch August 26, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants