-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8114: Verify fixed uitests in ControlRecordingsTest on jdk 17 #575
Conversation
👋 Welcome back aptmac! A progress list of the required criteria for merging this PR into |
@aptmac This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 3 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 719b714.
Your commit was automatically rebased without conflicts. |
JMC-8114 (https://bugs.openjdk.org/browse/JMC-8114) is a follow-up to JMC-8175 (https://bugs.openjdk.org/browse/JMC-8175).
There were a handful of uitests in ControlRecordingsTest that were failing, and were ignored until this backport was released in 17.0.12: https://bugs.openjdk.org/browse/JDK-8328159.
They're passing again now, so the tests can be un-ignored and run again.
Having said that, I'm running into different flightrecorder uitest failures now, but can address that in a different issue.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/575/head:pull/575
$ git checkout pull/575
Update a local copy of the PR:
$ git checkout pull/575
$ git pull https://git.openjdk.org/jmc.git pull/575/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 575
View PR using the GUI difftool:
$ git pr show -t 575
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/575.diff
Webrev
Link to Webrev Comment