8248: [Accessibility] Low Contrast in High Contrast mode on Stacktrace View

[Suchitainf]

This PR is to fix the accessibility issue for High Contrast mode. Stracktrace View was not readable at all in dark mode.

Before the fix:

After the fix:

---

Progress

• Commit message must refer to an issue
• Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

• JMC-8248: [Accessibility] Low Contrast in High Contrast mode on Stacktrace View (Bug - P4)

Reviewers

• Alex Macdonald (@aptmac - Reviewer)
• Brice Dutheil (@bric3 - Committer)

Contributors

• Marcus Hirt <hirt@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/580/head:pull/580
$ git checkout pull/580

Update a local copy of the PR:
$ git checkout pull/580
$ git pull https://git.openjdk.org/jmc.git pull/580/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 580

View PR using the GUI difftool:
$ git pr show -t 580

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/580.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back schaturvedi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@Suchitainf This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8248: [Accessibility] Low Contrast in High Contrast mode on Stacktrace View

Co-authored-by: Marcus Hirt <hirt@openjdk.org>
Reviewed-by: aptmac, bdutheil

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 05: Full - Incremental (c4f1aebd)
• 04: Full - Incremental (7f336a75)
• 03: Full - Incremental (ef4ba472)
• 02: Full - Incremental (fd2bcdf3)
• 01: Full - Incremental (8663a808)
• 00: Full (b74d29ea)

[bric3]

question: I would avoid the static final there, I think the themes can be dynamic, i.e. change without restarting ? If that's not the case maybe it can be in the future.

See the the comment on ThemeUtils to see a different approach.

[Suchitainf]

/contributor add @thegreystone

[openjdk]

@Suchitainf
Contributor Marcus Hirt <hirt@openjdk.org> successfully added.

[aptmac]

Brice has a good point here, applying themes can be dynamic so IS_DARK_MODE needs to be able to be updated.

[Suchitainf]

Hi @bric3 & @aptmac , I have implemented the suggested change. I have also added the property listener in the static block. There is no issue with the eclipse development environment. I have tried to build JMC outside also and the build is working perfectly fine. But seems like spotbugs is not happy with updating static variable isCurrentThemeDark from the listener. Hence, there are test failures due to that. Please have a look at the changes and let me know if I am missing something.

Hope I understood the suggestion clearly and implemented accordingly.

[openjdk]

⚠️ @Suchitainf This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

[Suchitainf]

Thanks @bric3 for approving the changes.

@aptmac Can you please take a look now? I need one reviewer's approval before integrating the changes. Thanks in advance.

[Suchitainf]

/integrate

[openjdk]

Going to push as commit 8c67664.

[openjdk]

@Suchitainf Pushed as commit 8c67664.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.