-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8260: Warnings and errors logged during XML processing #592
Conversation
👋 Welcome back vpurnam! A progress list of the required criteria for merging this PR into |
@viragpurnam This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
Ok. Let's open a new ticket, and then we can see if someone would be interested in declaring the schemas. The ticket can link this PR and explain what needs to be done. |
Thanks @thegreystone, I have created https://bugs.openjdk.org/browse/JMC-8273 and linked to JMC-8260 |
/integrate |
Going to push as commit cf85dbc. |
@viragpurnam Pushed as commit cf85dbc. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
We have several xml files in JMC. To remove fortify scan issue about XML Validation, DocumentBuilderFactory.setValidating(true) had been added. Because of that validation was triggered during the parsing of XML. We do not have xsd files against all the xml files and so it shows errors and warning.
We can either create xsd files or disable the ErrorValidator.
I think at this point disabling the default ErrorValidator is better option, and I have done the same in this PR.
Could you please review the changes. Thanks.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/592/head:pull/592
$ git checkout pull/592
Update a local copy of the PR:
$ git checkout pull/592
$ git pull https://git.openjdk.org/jmc.git pull/592/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 592
View PR using the GUI difftool:
$ git pr show -t 592
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/592.diff
Webrev
Link to Webrev Comment