Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

6712: Make agent retransform classes when loaded dynamically #60

Closed
wants to merge 2 commits into from
Closed

6712: Make agent retransform classes when loaded dynamically #60

wants to merge 2 commits into from

Conversation

jessyec-s
Copy link
Contributor

@jessyec-s jessyec-s commented Feb 28, 2020 •
edited by openjdk bot
Loading

This patch makes the Agent retransform all classes stored in the registry after it is loaded, when it is loaded dynamically. Previously the transformations specified in the xml file path argument were not always being performed in this dynamic case.

Let me know what you think.

Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-6712: Transformations defined in agent args not applied when loading dynamically

Reviewers

  • Marcus Hirt (hirt - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jmc pull/60/head:pull/60
$ git checkout pull/60

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 28, 2020

👋 Welcome back jescolem! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label Feb 28, 2020
@mlbridge
Copy link

mlbridge bot commented Feb 28, 2020 •
edited
Loading

Webrevs

thegreystone
thegreystone reviewed Mar 1, 2020
View reviewed changes
agent/src/main/java/org/openjdk/jmc/agent/impl/DefaultTransformRegistry.java Outdated
@@ -456,6 +456,10 @@ public String toString() {
return classNames;
}

public List<String> getClassNames() {
return new ArrayList<>(transformData.keySet());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This data comes from a set. Any reason for it to be made into a list (implies order, where there is none)? Wrap in Collections#unmodifiableSet?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are correct I have fixed this in 6dfb028

@openjdk
Copy link

openjdk bot commented Mar 3, 2020 •
edited
Loading

@jessyec-s This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

6712: Make agent retransform classes when loaded dynamically

Reviewed-by: hirt
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 091557481664b611696dc858ce459ebf06f7b3ba.

As you do not have Committer status in this project, an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@thegreystone) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Mar 3, 2020
@jessyec-s
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 3, 2020

@jessyec-s
Your change (at version 6dfb028) is now ready to be sponsored by a Committer.

@openjdk openjdk bot added the sponsor label Mar 3, 2020
@thegreystone
Copy link
Member

/sponsor

@thegreystone
Copy link
Member

Thanks Jessye! :)

@openjdk openjdk bot closed this Mar 3, 2020
@openjdk openjdk bot added integrated and removed sponsor labels Mar 3, 2020
@openjdk
Copy link

openjdk bot commented Mar 3, 2020

@thegreystone @jessyec-s The following commits have been pushed to master since your change was applied:

  • 0915574: 6700: Make Flame Graph compile on Photon

Your commit was automatically rebased without conflicts.

Pushed as commit 49da554.

@openjdk openjdk bot removed ready rfr labels Mar 3, 2020
@mlbridge
Copy link

mlbridge bot commented Mar 3, 2020

Mailing list message from Marcus Hirt on jmc-dev:

Changeset: 49da554
Author: Jessye Coleman-Shapiro <jescolem at openjdk.org>
Committer: Marcus Hirt <hirt at openjdk.org>
Date: 2020-03-03 19:17:11 +0000
URL: https://git.openjdk.java.net/jmc/commit/49da5546

6712: Make agent retransform classes when loaded dynamically

Reviewed-by: hirt

! agent/src/main/java/org/openjdk/jmc/agent/Agent.java
! agent/src/main/java/org/openjdk/jmc/agent/TransformRegistry.java
! agent/src/main/java/org/openjdk/jmc/agent/impl/DefaultTransformRegistry.java

@jessyec-s jessyec-s deleted the jmc-6712 branch July 28, 2020 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thegreystone thegreystone thegreystone approved these changes

Assignees
No one assigned
Labels
integrated
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jessyec-s @thegreystone