Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6700: Make Flame Graph compile on Photon #61

Conversation

@mirage22
Copy link
Collaborator

@mirage22 mirage22 commented Mar 2, 2020

correction to compatibility with Photon


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-6700: Make Flame Graph compile on Photon

Reviewers

  • Marcus Hirt (hirt - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jmc pull/61/head:pull/61
$ git checkout pull/61

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 2, 2020

👋 Welcome back mwengner! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label Mar 2, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 2, 2020

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Mar 3, 2020

@mirage22 This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

6700: Make Flame Graph compile on Photon

Reviewed-by: hirt
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

As you do not have Committer status in this project, an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@thegreystone) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Mar 3, 2020
@mirage22
Copy link
Collaborator Author

@mirage22 mirage22 commented Mar 3, 2020

/integrate

@openjdk openjdk bot added the sponsor label Mar 3, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Mar 3, 2020

@mirage22
Your change (at version 893156c) is now ready to be sponsored by a Committer.

@thegreystone
Copy link
Member

@thegreystone thegreystone commented Mar 3, 2020

/sponsor

@openjdk openjdk bot closed this Mar 3, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Mar 3, 2020

@thegreystone @mirage22
Pushed as commit 0915574.

@thegreystone
Copy link
Member

@thegreystone thegreystone commented Mar 3, 2020

Thanks Miro! :)

@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 3, 2020

Mailing list message from Marcus Hirt on jmc-dev:

Changeset: 0915574
Author: Miroslav Wengner <mwengner at openjdk.org>
Committer: Marcus Hirt <hirt at openjdk.org>
Date: 2020-03-03 19:16:31 +0000
URL: https://git.openjdk.java.net/jmc/commit/09155748

6700: Make Flame Graph compile on Photon

Reviewed-by: hirt

! application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/views/FlameGraphView.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants