Skip to content

8295: Shutdown event type id is not properly translated for Oracle JDK 8 #614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

thegreystone
Copy link
Member

@thegreystone thegreystone commented Dec 3, 2024

The conversion from the legacy jfr 0.9 id wasn't happening for the VM shutdown event.


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JMC-8295: Shutdown event type id is not properly translated for Oracle JDK 8 (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/614/head:pull/614
$ git checkout pull/614

Update a local copy of the PR:
$ git checkout pull/614
$ git pull https://git.openjdk.org/jmc.git pull/614/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 614

View PR using the GUI difftool:
$ git pr show -t 614

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/614.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 3, 2024

👋 Welcome back hirt! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 3, 2024

@thegreystone This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295: Shutdown event type id is not properly translated for Oracle JDK 8

Reviewed-by: vpurnam

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • cbf7349: 8298: Update to Eclipse 2024-09

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr label Dec 3, 2024
@mlbridge
Copy link

mlbridge bot commented Dec 3, 2024

Webrevs

@openjdk openjdk bot added the ready label Dec 7, 2024
@thegreystone
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 9, 2024

Going to push as commit 254d795.
Since your change was applied there has been 1 commit pushed to the master branch:

  • cbf7349: 8298: Update to Eclipse 2024-09

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Dec 9, 2024
@openjdk openjdk bot closed this Dec 9, 2024
@openjdk openjdk bot removed ready rfr labels Dec 9, 2024
@openjdk
Copy link

openjdk bot commented Dec 9, 2024

@thegreystone Pushed as commit 254d795.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants