Skip to content

Conversation

@skarsaune
Copy link
Contributor

@skarsaune skarsaune commented Dec 28, 2024

The fix for https://bugs.openjdk.org/browse/JMC-7539 does not work as intended as the JDP multicast tests reside in core due to https://bugs.openjdk.org/browse/JMC-7069


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JMC-8311: Ensure ./build.sh --installCore respects --skipJDPMulticastTests (Bug - P4) ⚠️ Issue is not open.

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/619/head:pull/619
$ git checkout pull/619

Update a local copy of the PR:
$ git checkout pull/619
$ git pull https://git.openjdk.org/jmc.git pull/619/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 619

View PR using the GUI difftool:
$ git pr show -t 619

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/619.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 28, 2024

👋 Welcome back skarsaune! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 28, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@skarsaune skarsaune changed the title JMC-8311: Ensure installCore respects avoiding JDP tests JMC-8311: Ensure ./build.sh --installCore respects --skipJDPMulticastTests Dec 28, 2024
@openjdk openjdk bot changed the title JMC-8311: Ensure ./build.sh --installCore respects --skipJDPMulticastTests 8311: Ensure ./build.sh --installCore respects --skipJDPMulticastTests Dec 28, 2024
@openjdk openjdk bot added the rfr label Dec 28, 2024
@mlbridge
Copy link

mlbridge bot commented Dec 28, 2024

Webrevs

@skarsaune
Copy link
Contributor Author

Duplicate of #611

@skarsaune skarsaune closed this Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

1 participant