8385: Upgrade hashing algorithm

[Suchitainf]

Upgrading hashing algorithm as part of this PR.

---

Progress

• Commit message must refer to an issue
• Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

• JMC-8385: Upgrade hashing algorithm (Enhancement - P3)

Reviewers

• Marcus Hirt (@thegreystone - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/641/head:pull/641
$ git checkout pull/641

Update a local copy of the PR:
$ git checkout pull/641
$ git pull https://git.openjdk.org/jmc.git pull/641/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 641

View PR using the GUI difftool:
$ git pr show -t 641

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/641.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back schaturvedi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@Suchitainf This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8385: Upgrade hashing algorithm

Reviewed-by: hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

• a0c39bc: 8394: Views should not be named view
• db49d80: 8392: Memory view on MacOS keeps reverting to aggregate trace list
• 62574d8: 8395: Thread ID is not properly visible on hover for Mac
• ... and 5 more: https://git.openjdk.org/jmc/compare/688063ad4c2187cd36221635a532ac821224bd93...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 01: Full - Incremental (7f906dd8)
• 00: Full (523db613)

[bric3]

I lack context on this, but what about older HmacSHA1 backward compat.

[Suchitainf]

I lack context on this, but what about older HmacSHA1 backward compat.

As per my understanding, this will be called on the initialization of UIPlugin. So when, user will install new version of JMC (i.e. 10) the algorithm will be initialized to latest one instead of the older one. The older passwords saved for previous release will anyways be null and void and will not be applicable for new release. Hence backward compatibility is not required here.

[Suchitainf]

/integrate

[openjdk]

Going to push as commit e2005f3.
Since your change was applied there have been 8 commits pushed to the master branch:

• a0c39bc: 8394: Views should not be named view
• db49d80: 8392: Memory view on MacOS keeps reverting to aggregate trace list
• 62574d8: 8395: Thread ID is not properly visible on hover for Mac
• ... and 5 more: https://git.openjdk.org/jmc/compare/688063ad4c2187cd36221635a532ac821224bd93...master

Your commit was automatically rebased without conflicts.

[openjdk]

@Suchitainf Pushed as commit e2005f3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.