Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6701: Supporting LZ4 compressed recordings #65

Closed
wants to merge 3 commits into from

Conversation

@thegreystone
Copy link
Member

@thegreystone thegreystone commented Mar 11, 2020

What it says in the PR title. ;)


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-6701: Support LZ4 compressed recordings in JMC core

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jmc pull/65/head:pull/65
$ git checkout pull/65

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 12, 2020

👋 Welcome back hirt! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label Mar 12, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 12, 2020

Webrevs

@Gunde
Gunde approved these changes Mar 12, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Mar 12, 2020

@thegreystone This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

6701: Supporting LZ4 compressed recordings

Reviewed-by: hdafgard
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Mar 12, 2020
@thegreystone
Copy link
Member Author

@thegreystone thegreystone commented Mar 12, 2020

/integrate

@openjdk openjdk bot closed this Mar 12, 2020
@openjdk openjdk bot added integrated and removed ready labels Mar 12, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Mar 12, 2020

@thegreystone
Pushed as commit b6e5bde.

@openjdk openjdk bot removed the rfr label Mar 12, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 12, 2020

Mailing list message from Marcus Hirt on jmc-dev:

Changeset: b6e5bde
Author: Marcus Hirt <hirt at openjdk.org>
Date: 2020-03-12 22:58:51 +0000
URL: https://git.openjdk.java.net/jmc/commit/b6e5bde2

6701: Supporting LZ4 compressed recordings

Reviewed-by: hdafgard

! core/org.openjdk.jmc.common/META-INF/MANIFEST.MF
! core/org.openjdk.jmc.common/pom.xml
! core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/io/IOToolkit.java
! core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/messages/internal/Messages.java
! core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/util/XmlToolkit.java
! core/org.openjdk.jmc.common/src/main/resources/org/openjdk/jmc/common/messages/internal/messages.properties
! core/org.openjdk.jmc.flightrecorder.rules/pom.xml
! core/tests/org.openjdk.jmc.common.test/build.properties
! core/tests/org.openjdk.jmc.common.test/src/test/java/org/openjdk/jmc/common/util/IOToolkitTest.java
+ core/tests/org.openjdk.jmc.common.test/src/test/resources/test.txt
+ core/tests/org.openjdk.jmc.common.test/src/test/resources/test.txt.gz
+ core/tests/org.openjdk.jmc.common.test/src/test/resources/test.txt.lz4
+ core/tests/org.openjdk.jmc.common.test/src/test/resources/test.txt.zip
! license/THIRDPARTYREADME.txt
! releng/platform-definitions/platform-definition-2019-09/platform-definition-2019-09.target
! releng/platform-definitions/platform-definition-2019-12/platform-definition-2019-12.target
! releng/platform-definitions/platform-definition-photon/platform-definition-photon.target
! releng/third-party/pom.xml

@thegreystone thegreystone deleted the thegreystone:lz4support branch Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants