Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6778: Removing dependency on OPS4j maven repo and javax.mail:dsn #73

Conversation

@thegreystone
Copy link
Member

@thegreystone thegreystone commented May 6, 2020

Also upgrading jakarta.mail.


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-6778: OPS4J Maven Repo no longer available

Reviewers

  • Jie Kang (jkang - Author)
  • Henrik Dafgård (hdafgard - Reviewer)
  • Guru Hb (ghb - Reviewer)

Contributors

  • Jason Zaugg <jzaugg@gmail.com>

Download

$ git fetch https://git.openjdk.java.net/jmc pull/73/head:pull/73
$ git checkout pull/73

…o upgrading jakarta.mail
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 6, 2020

👋 Welcome back hirt! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label May 6, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented May 6, 2020

Webrevs

@jiekang
jiekang approved these changes May 6, 2020
Copy link
Collaborator

@jiekang jiekang left a comment

Works for me.

I'm curious what dsn was used for before, or intended to be used for.

@Gunde
Gunde approved these changes May 6, 2020
Copy link
Collaborator

@Gunde Gunde left a comment

Ship it!

@openjdk
Copy link

@openjdk openjdk bot commented May 6, 2020

@thegreystone This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

6778: Removing dependency on OPS4j maven repo and javax.mail:dsn

Co-authored-by: Jason Zaugg <jzaugg@gmail.com>
Reviewed-by: jkang, hdafgard, ghb
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

There are currently no new commits on the master branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate bacb448fd4ed1a9a5d887c50aebff4e854d3512a.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label May 6, 2020
@thegreystone
Copy link
Member Author

@thegreystone thegreystone commented May 6, 2020

/contributor add @retronym

@openjdk
Copy link

@openjdk openjdk bot commented May 6, 2020

@thegreystone Could not parse @retronym as a valid contributor.
Syntax: /contributor (add|remove) [@user | openjdk-user | Full Name <email@address>]. For example:

  • /contributor add @openjdk-bot
  • /contributor add duke
  • /contributor add J. Duke <duke@openjdk.org>
@openjdk openjdk bot deleted a comment from openjdk bot May 6, 2020
@openjdk openjdk bot deleted a comment from openjdk bot May 6, 2020
@guruhb
guruhb approved these changes May 7, 2020
Copy link
Collaborator

@guruhb guruhb left a comment

Looks good to me

@thegreystone
Copy link
Member Author

@thegreystone thegreystone commented May 7, 2020

/contributor add Jason Zaugg jzaugg@gmail.com

@openjdk
Copy link

@openjdk openjdk bot commented May 7, 2020

@thegreystone
Contributor Jason Zaugg <jzaugg@gmail.com> successfully added.

@thegreystone
Copy link
Member Author

@thegreystone thegreystone commented May 7, 2020

/integrate

@openjdk openjdk bot closed this May 7, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels May 7, 2020
@openjdk
Copy link

@openjdk openjdk bot commented May 7, 2020

@thegreystone
Pushed as commit 9036f22.

@thegreystone thegreystone deleted the thegreystone:fix-java-mail-repo-dependency branch May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.