Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

6542: Improve calls to render in the flame view #78

Closed
wants to merge 37 commits into from
Closed

6542: Improve calls to render in the flame view #78

wants to merge 37 commits into from

Conversation

mirage22
Copy link
Collaborator

@mirage22 mirage22 commented Jun 2, 2020 •
edited by openjdk bot
Loading

stable flameview generation

Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-6542: Improve calls to render in the flame view

Download

$ git fetch https://git.openjdk.java.net/jmc pull/78/head:pull/78
$ git checkout pull/78

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 2, 2020

👋 Welcome back mwengner! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label Jun 2, 2020
@mlbridge
Copy link

mlbridge bot commented Jun 2, 2020 •
edited
Loading

Webrevs

@thegreystone
Copy link
Member

Sadly I can still make it go out of whack with these changes:
image

@mirage22
Copy link
Collaborator Author

mirage22 commented Jun 9, 2020

I've add a fix.

@mirage22
Copy link
Collaborator Author

mirage22 commented Jun 9, 2020

maybe we can increase the Executor treads in FlameView, I've observed improvements. But calculating the model is still expensive.

@thegreystone
Copy link
Member

Seems formatting fails.

@mirage22
Copy link
Collaborator Author

JMC-6669 ticket, can be most probably also closed by this branch https://bugs.openjdk.java.net/browse/JMC-6669

@mirage22 mirage22 closed this Oct 18, 2020
@mirage22
Copy link
Collaborator Author

found the issue. better to open a new branch

@mirage22 mirage22 deleted the feature/6542_Improve_calls_to_render_in_the_flame_view branch October 18, 2020 19:43
RealCLanger added a commit to RealCLanger/jmc that referenced this pull request Jul 5, 2024
@RealCLanger
Merge pull request openjdk#78 from SAP/pr-92750098a2deac54b8165ec5c6d…
ba981fb 
…368be00707856-sap

sap: Merge 9275009
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thegreystone thegreystone thegreystone requested changes

Assignees
No one assigned
Labels
rfr
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mirage22 @thegreystone