6542: Improve calls to render in the flame view #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Welcome back mwengner! A progress list of the required criteria for merging this PR into |
Webrevs
|
thegreystone
reviewed
Jun 3, 2020
...htrecorder/src/main/java/org/openjdk/jmc/flightrecorder/stacktrace/StacktraceModelUtils.java
Outdated
Show resolved
Hide resolved
Member
|
Sadly I can still make it go out of whack with these changes: |
Collaborator
Author
|
I've add a fix. |
Collaborator
Author
|
maybe we can increase the Executor treads in FlameView, I've observed improvements. But calculating the model is still expensive. |
…6542_Improve_calls_to_render_in_the_flame_view
…6542_Improve_calls_to_render_in_the_flame_view
Member
|
Seems formatting fails. |
…6542_Improve_calls_to_render_in_the_flame_view
Collaborator
Author
|
JMC-6669 ticket, can be most probably also closed by this branch https://bugs.openjdk.java.net/browse/JMC-6669 |
...ecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/tree/TraceNode.java
Outdated
Show resolved
Hide resolved
thegreystone
requested changes
Oct 9, 2020
...ecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/tree/TraceNode.java
Outdated
Show resolved
Hide resolved
...r.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/views/FlameGraphView.java
Outdated
Show resolved
Hide resolved
…6542_Improve_calls_to_render_in_the_flame_view
Collaborator
Author
|
found the issue. better to open a new branch |
mirage22
deleted the
feature/6542_Improve_calls_to_render_in_the_flame_view
branch
RealCLanger
added a commit
to RealCLanger/jmc
that referenced
this pull request
Jul 5, 2024
…368be00707856-sap sap: Merge 9275009
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stable flameview generation
Progress
Issue
Download
$ git fetch https://git.openjdk.java.net/jmc pull/78/head:pull/78$ git checkout pull/78