Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6847: Upgrading to the Eclipse 2020-06 platform #85

Closed

Conversation

@thegreystone
Copy link
Member

@thegreystone thegreystone commented Jun 22, 2020

Note that this one should probably go in after we get JMC-6838 in. That said, we can review it and get it ready for show-time.


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-6847: Add 2020-06 platform ⚠️ Title mismatch between PR and JBS.

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jmc pull/85/head:pull/85
$ git checkout pull/85

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 22, 2020

👋 Welcome back hirt! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label Jun 22, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 22, 2020

Webrevs

Gunde
Gunde approved these changes Jun 24, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jun 24, 2020

@thegreystone This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

6847: Upgrading to the Eclipse 2020-06 platform

Reviewed-by: hdafgard
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch:

  • 77d4b13: 6833: Tolerate exceptions when loading images

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 77d4b13a3818dd468723ff8bb86bcb8433888060.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 24, 2020
@thegreystone
Copy link
Member Author

@thegreystone thegreystone commented Jun 24, 2020

/integrate

@openjdk openjdk bot closed this Jun 24, 2020
@openjdk openjdk bot added integrated and removed ready labels Jun 24, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jun 24, 2020

@thegreystone The following commits have been pushed to master since your change was applied:

  • 77d4b13: 6833: Tolerate exceptions when loading images

Your commit was automatically rebased without conflicts.

Pushed as commit 0a1c4b3.

@openjdk openjdk bot removed the rfr label Jun 24, 2020
@thegreystone thegreystone deleted the 6847-2020-06-platform branch Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants