Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6833: Tolerate exceptions when loading images #86

Closed
wants to merge 1 commit into from

Conversation

@cimi
Copy link
Contributor

@cimi cimi commented Jun 23, 2020

This PR fixes the crash reported in 6833 by returning null in case there's an error reading UI images.

During manual testing I noticed that the icon for Method Profiling can't be loaded on my system and this was causing the application to crash. I didn't find other resources with this problem.


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-6833: Error when viewing the Java Application page ⚠️ Title mismatch between PR and JBS.

Reviewers

  • Marcus Hirt (hirt - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jmc pull/86/head:pull/86
$ git checkout pull/86

@bridgekeeper bridgekeeper bot added the oca label Jun 23, 2020
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 23, 2020

Hi @cimi, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user cimi" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@cimi
Copy link
Contributor Author

@cimi cimi commented Jun 23, 2020

/covered

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 23, 2020

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@cimi cimi force-pushed the cimi:ui-resource-exceptions branch from c733dea to 129f20e Jun 23, 2020
@openjdk openjdk bot added the rfr label Jun 24, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 24, 2020

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Jun 24, 2020

@cimi This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

6833: Tolerate exceptions when loading images

Reviewed-by: hirt
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch:

  • 2edae36: 6835: Adding developer guide for getting started with development

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 2edae36405116091e34841ff646b31009c74de84.

As you are not a known OpenJDK Author, an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@thegreystone) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Jun 24, 2020
@cimi
Copy link
Contributor Author

@cimi cimi commented Jun 24, 2020

/integrate

@openjdk openjdk bot added the sponsor label Jun 24, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jun 24, 2020

@cimi
Your change (at version 129f20e) is now ready to be sponsored by a Committer.

@thegreystone
Copy link
Member

@thegreystone thegreystone commented Jun 24, 2020

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Jun 24, 2020

@thegreystone @cimi The following commits have been pushed to master since your change was applied:

  • 2edae36: 6835: Adding developer guide for getting started with development

Your commit was automatically rebased without conflicts.

Pushed as commit 77d4b13.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants