Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6639: Fixing whitespace error on Mac #9

Closed
wants to merge 2 commits into from

Conversation

@thegreystone
Copy link
Collaborator

thegreystone commented Nov 28, 2019

Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

JMC-6639: Introduce spotless for the rest of the JMC project

Approvers

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 28, 2019

👋 Welcome back hirt! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@openjdk openjdk bot added the rfr label Nov 28, 2019
@mlbridge
Copy link

mlbridge bot commented Nov 28, 2019

Webrevs

@Gunde
Gunde approved these changes Nov 28, 2019
@openjdk openjdk bot removed the rfr label Nov 28, 2019
@openjdk
Copy link

openjdk bot commented Nov 28, 2019

@thegreystone This change can now be integrated. The commit message will be:

6639: Fixing whitespace error on Mac

Reviewed-by: hdafgard
  • If you would like to add a summary, use the /summary command.
  • To list additional contributors, use the /contributor command.
  • To integrate this PR with the above commit message, type /integrate in a new comment.
@openjdk openjdk bot added the ready label Nov 28, 2019
@thegreystone
Copy link
Collaborator Author

thegreystone commented Nov 28, 2019

/integrate

@openjdk openjdk bot closed this Nov 28, 2019
@openjdk openjdk bot added integrated and removed ready labels Nov 28, 2019
@openjdk
Copy link

openjdk bot commented Nov 28, 2019

@thegreystone
Pushed as commit 44a9a67.

@mlbridge
Copy link

mlbridge bot commented Nov 28, 2019

Mailing list message from Marcus Hirt on jmc-dev:

Changeset: 44a9a67
Author: Marcus Hirt
Date: 2019-11-28 12:58:22 +0000
URL: https://git.openjdk.java.net/jmc/commit/44a9a676

6639: Fixing whitespace error on Mac

Reviewed-by: hdafgard

! application/org.openjdk.jmc.alert/src/main/java/org/openjdk/jmc/alert/AlertDialog.java
! application/uitests/org.openjdk.jmc.flightrecorder.uitest/src/test/java/org/openjdk/jmc/flightrecorder/uitest/pages/SocketIOPageTest.java

@thegreystone thegreystone deleted the thegreystone:whitespacefix branch Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.