Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6858: Thread dump does not show complete call stack based for all threads (grouped by time) #90

Closed
wants to merge 1 commit into from

Conversation

@Suchitainf
Copy link
Collaborator

@Suchitainf Suchitainf commented Jun 29, 2020

Thread dump does not show complete call stack based on all threads (grouped by time) in first shot.

The user need to click on each sub sections of the sub-tree to see the corresponding thread dumps. But the user wanted to see full thread dump in one shot as soon as they click on timestamp mentioned. Attached the screenshots of the functionality before and after fix.

Before fix

JMC_6170

After fix

JMC_6170_Fixed

--------- ### Progress - [x] Commit message must refer to an issue - [x] Change must be properly reviewed

Issue

  • JMC-6858: Thread dump does not show complete call stack based for all threads (grouped by time)

Reviewers

  • Guru Hb (ghb - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jmc pull/90/head:pull/90
$ git checkout pull/90

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 29, 2020

Hi @Suchitainf, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user Suchitainf" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@bridgekeeper bridgekeeper bot added oca and removed oca labels Jun 29, 2020
@openjdk openjdk bot added the rfr label Jun 30, 2020
@Suchitainf Suchitainf changed the title 6858: Thread dump does not show complete call stack based on all threads 6858: Thread dump does not show complete call stack based on all threads (grouped by time) Jun 30, 2020
@Suchitainf Suchitainf changed the title 6858: Thread dump does not show complete call stack based on all threads (grouped by time) 6858: Thread dump does not show complete call stack based for all threads (grouped by time) Jun 30, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 30, 2020

Webrevs

guruhb
guruhb approved these changes Jun 30, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jun 30, 2020

@Suchitainf This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

6858: Thread dump does not show complete call stack based for all threads (grouped by time)

Reviewed-by: ghb
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch:

  • 3eb5cb2: 6805: Event emission only on exceptions

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 3eb5cb2b915fa3c93a91357034dadca9bd63d1f9.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 30, 2020
@thegreystone
Copy link
Member

@thegreystone thegreystone commented Jun 30, 2020

Hi there! Did you try this out with some massive thread stack dumps?

@Suchitainf
Copy link
Collaborator Author

@Suchitainf Suchitainf commented Jun 30, 2020

Hi there! Did you try this out with some massive thread stack dumps?

Hi Marcus! Yes I have tested it with a JFR which is basically a sample data for wls. If you have some particular jfr for which this fix should be tested, please provide the same. I would be happy to verify the same.

@Suchitainf
Copy link
Collaborator Author

@Suchitainf Suchitainf commented Jul 3, 2020

/integrate

@openjdk openjdk bot closed this Jul 3, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 3, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jul 3, 2020

@Suchitainf The following commits have been pushed to master since your change was applied:

  • 3eb5cb2: 6805: Event emission only on exceptions

Your commit was automatically rebased without conflicts.

Pushed as commit aeb8ae4.

@thegreystone thegreystone mentioned this pull request Jul 14, 2020
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants