-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
6864: Schema definition doesn't have optional ReturnValue "name" property #94
Conversation
👋 Welcome back jescolem! A progress list of the required criteria for merging this PR into |
@jessyec-s This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type
Since the source branch of this PR was last updated there has been 1 commit pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge As you do not have Committer status in this project, an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@thegreystone) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
@jessyec-s |
The formatting error making the tests fail has been fixed in master. Will sponsor this now. |
/sponsor |
@thegreystone @jessyec-s The following commits have been pushed to master since your change was applied:
Your commit was automatically rebased without conflicts. Pushed as commit db472f6. |
…acda148455b3e-sap sap: Merge cf85dbc
This patch adds an optional return value "name" property to the Agent schema. You are currently able to add this "name" property to your event probe, however, adding it to the schema was missed in the reviewing process of JMC-6725.
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jmc pull/94/head:pull/94
$ git checkout pull/94