Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6864: Schema definition doesn't have optional ReturnValue "name" property #94

Closed
wants to merge 1 commit into from

Conversation

jessyec-s
Copy link
Contributor

@jessyec-s jessyec-s commented Jul 13, 2020

This patch adds an optional return value "name" property to the Agent schema. You are currently able to add this "name" property to your event probe, however, adding it to the schema was missed in the reviewing process of JMC-6725.


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-6864: Schema definition doesn't have optional ReturnValue "name" property

Reviewers

  • Marcus Hirt (hirt - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jmc pull/94/head:pull/94
$ git checkout pull/94

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 13, 2020

👋 Welcome back jescolem! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label Jul 13, 2020
@mlbridge
Copy link

mlbridge bot commented Jul 13, 2020

Webrevs

@openjdk
Copy link

openjdk bot commented Jul 13, 2020

@jessyec-s This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

6864: Schema definition doesn't have optional ReturnValue "name" property

Reviewed-by: hirt
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch:

  • 37fef29: 6869: Fix formatting error

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 37fef29677af36c5bf8a3ff6ac9b1e4c677060eb.

As you do not have Committer status in this project, an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@thegreystone) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Jul 13, 2020
@jessyec-s
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor label Jul 13, 2020
@openjdk
Copy link

openjdk bot commented Jul 13, 2020

@jessyec-s
Your change (at version e9ea0aa) is now ready to be sponsored by a Committer.

@thegreystone
Copy link
Member

The formatting error making the tests fail has been fixed in master. Will sponsor this now.

@thegreystone
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jul 15, 2020

@thegreystone @jessyec-s The following commits have been pushed to master since your change was applied:

  • 37fef29: 6869: Fix formatting error

Your commit was automatically rebased without conflicts.

Pushed as commit db472f6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants