Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6871: Upgrade to ASM 8.0.1 #96

Closed
wants to merge 1 commit into from

Conversation

thegreystone
Copy link
Member

@thegreystone thegreystone commented Jul 19, 2020

Also, updating expectations to (at least) JDK 8, as core and the rest of JMC 8 will require 8.


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

  • Guru Hb (ghb - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jmc pull/96/head:pull/96
$ git checkout pull/96

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 19, 2020

👋 Welcome back hirt! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label Jul 19, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 19, 2020

Webrevs

guruhb
guruhb approved these changes Jul 21, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jul 21, 2020

@thegreystone This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

6871: Upgrade to ASM 8.0.1

Reviewed-by: ghb
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 7 commits pushed to the master branch:

  • 7b9b244: 6855: Should add information about where to get builds to README
  • db472f6: 6864: Schema definition doesn't have optional ReturnValue "name" property
  • 37fef29: 6869: Fix formatting error
  • bfdc3eb: 6810: Create treemap viewer for JOverflow
  • ddb8dac: 6852: Extracted layout for the JMC RCP binaries look not the same for Linux/Windows
  • aeb8ae4: 6858: Thread dump does not show complete call stack based for all threads (grouped by time)
  • 3eb5cb2: 6805: Event emission only on exceptions

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 7b9b244693e1d1a764f0d804c3bbe291dfa86c87.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jul 21, 2020
@thegreystone
Copy link
Member Author

@thegreystone thegreystone commented Jul 21, 2020

/integrate

@openjdk openjdk bot closed this Jul 21, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 21, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jul 21, 2020

@thegreystone The following commits have been pushed to master since your change was applied:

  • 7b9b244: 6855: Should add information about where to get builds to README
  • db472f6: 6864: Schema definition doesn't have optional ReturnValue "name" property
  • 37fef29: 6869: Fix formatting error
  • bfdc3eb: 6810: Create treemap viewer for JOverflow
  • ddb8dac: 6852: Extracted layout for the JMC RCP binaries look not the same for Linux/Windows
  • aeb8ae4: 6858: Thread dump does not show complete call stack based for all threads (grouped by time)
  • 3eb5cb2: 6805: Event emission only on exceptions

Your commit was automatically rebased without conflicts.

Pushed as commit ee09e86.

@thegreystone thegreystone deleted the 6871-upgrade-asm branch Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants